Linux ocfs2 filesystem development
 help / color / mirror / Atom feed
From: ryding <ryan.ding@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Fill-in the unused portion of the block with zeros by dio_zero_block()
Date: Thu, 10 Sep 2015 09:53:11 +0800	[thread overview]
Message-ID: <55F0E287.1020701@oracle.com> (raw)
In-Reply-To: <55EF9184.5090007@huawei.com>

Hi Yiwen,

I'm working on this issue. The patch will be send out soon. And the 
issue that do not support file hole will be fixed too. I have proved it 
can pass all ltp-aiodio test cases, and has better performance. ;-)

Thanks,
Ryan


On 09/09/2015 09:55 AM, jiangyiwen wrote:
> A simplified test case is (this case from Ryan):
> 1) dd if=/dev/zero of=/mnt/hello bs=512 count=1 oflag=direct;
> 2) truncate /mnt/hello -s 2097152
> file 'hello' is not exist before test. After this command,
> file 'hello' should be all zero. But 512~4096 is some random data.
>
> Setting bh state to new when get a new block, if so,
> direct_io_worker()->dio_zero_block() will fill-in the unused portion
> of the block with zero.
>
> Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com>
> ---
>   fs/ocfs2/aops.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
> index 1a35c61..bd106b9 100644
> --- a/fs/ocfs2/aops.c
> +++ b/fs/ocfs2/aops.c
> @@ -581,6 +581,7 @@ static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock,
>   			ret = -EIO;
>   			goto bail;
>   		}
> +		set_buffer_new(bh_result);
>   	}
>
>   	/*

  parent reply	other threads:[~2015-09-10  1:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09  1:55 [Ocfs2-devel] [PATCH] ocfs2: Fill-in the unused portion of the block with zeros by dio_zero_block() jiangyiwen
2015-09-09  2:13 ` Joseph Qi
2015-09-09  5:16 ` Zhen Ren
2015-09-09  9:13   ` Joseph Qi
2015-09-09 10:42     ` Zhen Ren
2015-09-10  1:48       ` jiangyiwen
2015-09-09  9:14   ` jiangyiwen
2015-09-10  1:53 ` ryding [this message]
2015-09-14 22:22   ` Andrew Morton
2015-09-15  2:34     ` ryding
2015-09-14 22:13 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F0E287.1020701@oracle.com \
    --to=ryan.ding@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox