From: Tariq Saeed <tariq.x.saeed@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang
Date: Thu, 07 Jan 2016 15:49:27 -0800 [thread overview]
Message-ID: <568EF987.9080904@oracle.com> (raw)
In-Reply-To: <20160107225507.GB819@wotan.suse.de>
On 01/07/2016 02:55 PM, Mark Fasheh wrote:
> So you could replace that last paragraph with something like this:
>
> The deleted version of ocfs2_acl_chmod() calls __posix_acl_chmod() which
> does not call back into the filesystem. Therefore, we restore
> ocfs2_acl_chmod() and use that instead.
Thanks for reviewing. I have two more code paths to fix.
1. ocfs2_mknod()->posix_acl_create()->ocfs2_iop_get_acl()
2. ocfs2_reflink -> ocfs2_init_security_and_acl -> ocfs2_iop_set_acl
I will make your suggested change and submit again
a 3-part patch, including the above two.
-Tariq
next prev parent reply other threads:[~2016-01-07 23:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 2:27 [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang Tariq Saeed
2016-01-06 4:41 ` Junxiao Bi
2016-01-07 2:51 ` Tariq Saeed
2016-01-07 22:37 ` Tariq Saeed
2016-01-08 0:13 ` Tariq Saeed
2016-01-07 22:38 ` Tariq Saeed
2016-01-07 22:55 ` Mark Fasheh
2016-01-07 23:49 ` Tariq Saeed [this message]
2016-01-08 1:45 ` Mark Fasheh
2016-01-08 22:44 ` Tariq Saeed
2016-01-11 3:17 ` Junxiao Bi
2016-01-13 2:15 ` Junxiao Bi
-- strict thread matches above, loose matches on Subject: below --
2016-01-08 1:07 Tariq Saeed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EF987.9080904@oracle.com \
--to=tariq.x.saeed@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).