From: piaojun <piaojun@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean up unused variable in dlm_process_recovery_data
Date: Tue, 3 Apr 2018 13:48:31 +0800 [thread overview]
Message-ID: <5AC315AF.8050306@huawei.com> (raw)
In-Reply-To: <1522734135-7933-1-git-send-email-ge.changwei@h3c.com>
LGTM
On 2018/4/3 13:42, Changwei Ge wrote:
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Reviewed-by: Jun Piao <piaojun@huawei.com>
> ---
> fs/ocfs2/dlm/dlmrecovery.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index ec8f758..be6b067 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -1807,7 +1807,6 @@ static int dlm_process_recovery_data(struct dlm_ctxt *dlm,
> int i, j, bad;
> struct dlm_lock *lock;
> u8 from = O2NM_MAX_NODES;
> - unsigned int added = 0;
> __be64 c;
>
> mlog(0, "running %d locks for this lockres\n", mres->num_locks);
> @@ -1823,7 +1822,6 @@ static int dlm_process_recovery_data(struct dlm_ctxt *dlm,
> spin_lock(&res->spinlock);
> dlm_lockres_set_refmap_bit(dlm, res, from);
> spin_unlock(&res->spinlock);
> - added++;
> break;
> }
> BUG_ON(ml->highest_blocked != LKM_IVMODE);
> @@ -1911,7 +1909,6 @@ static int dlm_process_recovery_data(struct dlm_ctxt *dlm,
> /* do not alter lock refcount. switching lists. */
> list_move_tail(&lock->list, queue);
> spin_unlock(&res->spinlock);
> - added++;
>
> mlog(0, "just reordered a local lock!\n");
> continue;
> @@ -2037,7 +2034,6 @@ static int dlm_process_recovery_data(struct dlm_ctxt *dlm,
> "setting refmap bit\n", dlm->name,
> res->lockname.len, res->lockname.name, ml->node);
> dlm_lockres_set_refmap_bit(dlm, res, ml->node);
> - added++;
> }
> spin_unlock(&res->spinlock);
> }
>
next prev parent reply other threads:[~2018-04-03 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 5:42 [Ocfs2-devel] [PATCH] ocfs2/dlm: clean up unused variable in dlm_process_recovery_data Changwei Ge
2018-04-03 5:48 ` piaojun [this message]
2018-04-03 8:47 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AC315AF.8050306@huawei.com \
--to=piaojun@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).