From: Christoph Hellwig <hch@infradead.org>
To: Su Yue <glass.su@suse.com>
Cc: fstests@vger.kernel.org, ocfs2-devel@lists.linux.dev
Subject: Re: [PATCH] generic/420: skip test for ocfs2
Date: Mon, 6 Jan 2025 08:31:34 -0800 [thread overview]
Message-ID: <Z3wFZtcCPmr-vdsK@infradead.org> (raw)
In-Reply-To: <20250106140131.91946-1-glass.su@suse.com>
On Mon, Jan 06, 2025 at 10:01:31PM +0800, Su Yue wrote:
> ocfs2 doesn't support fallocate with
> mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE so skip it.
>
> Signed-off-by: Su Yue <glass.su@suse.com>
> ---
> tests/generic/420 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/420 b/tests/generic/420
> index edd9655fd3a3..e67442f8979b 100755
> --- a/tests/generic/420
> +++ b/tests/generic/420
> @@ -15,6 +15,7 @@ _begin_fstest auto quick punch
>
>
> # Modify as appropriate.
> +_supported_fs ^ocfs2
> _require_test
> _require_xfs_io_command fpunch
_require_xfs_io_command should be checking for hole punch
support. If that doesn't work we'll need to fix it instead
of throwing in undocumented blacklisting of file system types.
prev parent reply other threads:[~2025-01-06 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 14:01 [PATCH] generic/420: skip test for ocfs2 Su Yue
2025-01-06 16:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3wFZtcCPmr-vdsK@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=glass.su@suse.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).