From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emanuele Giuseppe Esposito Date: Mon, 20 Apr 2020 15:58:02 +0200 Subject: [Ocfs2-devel] [PATCH 4/8] fs: introduce simple_new_inode In-Reply-To: <20200414130140.GD720679@kroah.com> References: <20200414124304.4470-1-eesposit@redhat.com> <20200414124304.4470-5-eesposit@redhat.com> <20200414130140.GD720679@kroah.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: Song Liu , linux-usb@vger.kernel.org, bpf@vger.kernel.org, "Rafael J. Wysocki" , David Airlie , Heiko Carstens , Alexei Starovoitov , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , Joseph Qi , Hugh Dickins , Paul Mackerras , John Johansen , netdev@vger.kernel.org, ocfs2-devel@oss.oracle.com, Christoph Hellwig , Andrew Donnellan , Matthew Garrett , linux-efi@vger.kernel.org, Arnd Bergmann , Daniel Borkmann , Christian Borntraeger , linux-rdma@vger.kernel.org, Michael Ellerman , Mark Fasheh , Anton Vorontsov , John Fastabend , James Morris , Ard Biesheuvel , Jason Gunthorpe , Doug Ledford , oprofile-list@lists.sf.net, Yonghong Song , Ian Kent , Andrii Nakryiko , Alexey Dobriyan , "Serge E. Hallyn" , Robert Richter , Thomas Zimmermann , Vasily Gorbik , Tony Luck , Kees Cook , "James E.J. Bottomley" , autofs@vger.kernel.org, Mike Marciniszyn , linux-fsdevel@vger.kernel.org, "Manoj N. Kumar" , Uma Krishnan , Jakub Kicinski , KP Singh , Trond Myklebust , "Matthew R. Ochs" , "David S. Miller" , Felipe Balbi , linux-nfs@vger.kernel.org, Iurii Zaikin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, linux-s390@vger.kernel.org, Dennis Dalessandro , Miklos Szeredi , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Anna Schumaker , Luis Chamberlain , Chuck Lever , Jeremy Kerr , Colin Cross , Frederic Barrat , Paolo Bonzini , Andrew Morton , Mike Kravetz , linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau , Joel Becker , Alexander Viro On 4/14/20 3:01 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 02:42:58PM +0200, Emanuele Giuseppe Esposito wrote: >> It is a common special case for new_inode to initialize the >> time to the current time and the inode to get_next_ino(). >> Introduce a core function that does it and use it throughout >> Linux. > > Shouldn't this just be called new_inode_current_time()? > > How is anyone going to remember what simple_new_inode() does to the > inode structure? I noticed that most functions in libfs.c are called "simple_*" when they do the right thing for the majority of simple use cases (e.g., simple_symlink_inode_operations or simple_dir_operations). I can certainly rename the function. Thank you for all the feedback, I will incorporate it and send a new patch series soon. Emanuele > >> --- a/fs/libfs.c >> +++ b/fs/libfs.c >> @@ -595,6 +595,18 @@ int simple_write_end(struct file *file, struct address_space *mapping, >> } >> EXPORT_SYMBOL(simple_write_end); >> >> +struct inode *simple_new_inode(struct super_block *sb) >> +{ >> + struct inode *inode = new_inode(sb); >> + if (inode) { >> + inode->i_ino = get_next_ino(); >> + inode->i_atime = inode->i_mtime = >> + inode->i_ctime = current_time(inode); >> + } >> + return inode; >> +} >> +EXPORT_SYMBOL(simple_new_inode);