* drivers/gpu/drm/bridge/ti-sn65dsi86.c:1376:2-3: Unneeded semicolon
@ 2025-06-30 9:13 kernel test robot
2025-07-14 20:08 ` Doug Anderson
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-06-30 9:13 UTC (permalink / raw)
To: Jayesh Choudhary; +Cc: oe-kbuild-all, linux-kernel, Douglas Anderson
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af
commit: 55e8ff842051b1150461d7595d8f1d033c69d66b drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type
date: 5 days ago
config: s390-randconfig-r061-20250630 (https://download.01.org/0day-ci/archive/20250630/202506301704.0SBj6ply-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506301704.0SBj6ply-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:1376:2-3: Unneeded semicolon
vim +1376 drivers/gpu/drm/bridge/ti-sn65dsi86.c
1334
1335 static int ti_sn_bridge_probe(struct auxiliary_device *adev,
1336 const struct auxiliary_device_id *id)
1337 {
1338 struct ti_sn65dsi86 *pdata = dev_get_drvdata(adev->dev.parent);
1339 struct device_node *np = pdata->dev->of_node;
1340 int ret;
1341
1342 pdata->next_bridge = devm_drm_of_get_bridge(&adev->dev, np, 1, 0);
1343 if (IS_ERR(pdata->next_bridge))
1344 return dev_err_probe(&adev->dev, PTR_ERR(pdata->next_bridge),
1345 "failed to create panel bridge\n");
1346
1347 ti_sn_bridge_parse_lanes(pdata, np);
1348
1349 ret = ti_sn_bridge_parse_dsi_host(pdata);
1350 if (ret)
1351 return ret;
1352
1353 pdata->bridge.of_node = np;
1354 pdata->bridge.type = pdata->next_bridge->type == DRM_MODE_CONNECTOR_DisplayPort
1355 ? DRM_MODE_CONNECTOR_DisplayPort : DRM_MODE_CONNECTOR_eDP;
1356
1357 if (pdata->bridge.type == DRM_MODE_CONNECTOR_DisplayPort) {
1358 pdata->bridge.ops = DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT |
1359 DRM_BRIDGE_OP_HPD;
1360 /*
1361 * If comms were already enabled they would have been enabled
1362 * with the wrong value of HPD_DISABLE. Update it now. Comms
1363 * could be enabled if anyone is holding a pm_runtime reference
1364 * (like if a GPIO is in use). Note that in most cases nobody
1365 * is doing AUX channel xfers before the bridge is added so
1366 * HPD doesn't _really_ matter then. The only exception is in
1367 * the eDP case where the panel wants to read the EDID before
1368 * the bridge is added. We always consistently have HPD disabled
1369 * for eDP.
1370 */
1371 mutex_lock(&pdata->comms_mutex);
1372 if (pdata->comms_enabled)
1373 regmap_update_bits(pdata->regmap, SN_HPD_DISABLE_REG,
1374 HPD_DISABLE, 0);
1375 mutex_unlock(&pdata->comms_mutex);
> 1376 };
1377
1378 drm_bridge_add(&pdata->bridge);
1379
1380 ret = ti_sn_attach_host(adev, pdata);
1381 if (ret) {
1382 dev_err_probe(&adev->dev, ret, "failed to attach dsi host\n");
1383 goto err_remove_bridge;
1384 }
1385
1386 return 0;
1387
1388 err_remove_bridge:
1389 drm_bridge_remove(&pdata->bridge);
1390 return ret;
1391 }
1392
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/gpu/drm/bridge/ti-sn65dsi86.c:1376:2-3: Unneeded semicolon
2025-06-30 9:13 drivers/gpu/drm/bridge/ti-sn65dsi86.c:1376:2-3: Unneeded semicolon kernel test robot
@ 2025-07-14 20:08 ` Doug Anderson
0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2025-07-14 20:08 UTC (permalink / raw)
To: kernel test robot; +Cc: Jayesh Choudhary, oe-kbuild-all, linux-kernel
Hi,
On Mon, Jun 30, 2025 at 2:14 AM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af
> commit: 55e8ff842051b1150461d7595d8f1d033c69d66b drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type
> date: 5 days ago
> config: s390-randconfig-r061-20250630 (https://download.01.org/0day-ci/archive/20250630/202506301704.0SBj6ply-lkp@intel.com/config)
> compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506301704.0SBj6ply-lkp@intel.com/
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/gpu/drm/bridge/ti-sn65dsi86.c:1376:2-3: Unneeded semicolon
Posted:
https://lore.kernel.org/r/20250714130631.1.I1cfae3222e344a3b3c770d079ee6b6f7f3b5d636@changeid
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-14 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-30 9:13 drivers/gpu/drm/bridge/ti-sn65dsi86.c:1376:2-3: Unneeded semicolon kernel test robot
2025-07-14 20:08 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).