Re: [netfilter-nf:for-netdev-nf-26-11-13 27/27] net/netfilter/ipvs/ip_vs_conn.c:1060:21: error: use of undeclared identifier 'ip_vs_null_xmit_v6'; did you mean 'ip_vs_null_xmit'?

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Nov 13, 2026 at 02:15:33PM +0200, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Fri, 13 Nov 2026, Julian Anastasov wrote:
> 
> > On Fri, 13 Nov 2026, kernel test robot wrote:
> > 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git for-netdev-nf-26-11-13
> > > head:   937b060406a547e4d931525e600540726ea26532
> > > commit: 937b060406a547e4d931525e600540726ea26532 [27/27] ipvs: pass correct sk to update_pmtu and on tunneling
> > > config: i386-randconfig-2200-20261113 (https://download.01.org/0day-ci/archive/20261113/202611131204.pFzcf1WG-lkp@intel.com/config)
> > > compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
> > > smatch: v0.5.0-9187-g5189e3fb
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611131204.pFzcf1WG-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202611131204.pFzcf1WG-lkp@intel.com/
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > >> net/netfilter/ipvs/ip_vs_conn.c:1060:21: error: use of undeclared identifier 'ip_vs_null_xmit_v6'; did you mean 'ip_vs_null_xmit'?
> > >     1060 |                 cp->packet_xmit = ip_vs_null_xmit_v6;
> > >          |                                   ^~~~~~~~~~~~~~~~~~
> > >          |                                   ip_vs_null_xmit
> > >    include/net/ip_vs.h:1992:5: note: 'ip_vs_null_xmit' declared here
> > >     1992 | int ip_vs_null_xmit(struct sk_buff *skb, struct ip_vs_conn *cp,
> > >          |     ^
> > >    1 error generated.
> > > 
> > > 
> > > vim +1060 net/netfilter/ipvs/ip_vs_conn.c
> > > 
> > >   1034	
> > >   1035	/*
> > >   1036	 *	Bind a connection entry with the corresponding packet_xmit.
> > >   1037	 *	Called by ip_vs_conn_new.
> > >   1038	 */
> > >   1039	static inline void ip_vs_bind_xmit(struct ip_vs_conn *cp)
> > >   1040	{
> > >   1041		switch (IP_VS_FWD_METHOD(cp)) {
> > >   1042		case IP_VS_CONN_F_MASQ:
> > >   1043			cp->packet_xmit = ip_vs_nat_xmit;
> > >   1044			break;
> > >   1045	
> > >   1046		case IP_VS_CONN_F_TUNNEL:
> > >   1047	#ifdef CONFIG_IP_VS_IPV6
> > >   1048			if (cp->daf == AF_INET6)
> > >   1049				cp->packet_xmit = ip_vs_tunnel_xmit_v6;
> > >   1050			else
> > >   1051	#endif
> > >   1052				cp->packet_xmit = ip_vs_tunnel_xmit;
> > >   1053			break;
> > >   1054	
> > >   1055		case IP_VS_CONN_F_DROUTE:
> > >   1056			cp->packet_xmit = ip_vs_dr_xmit;
> > >   1057			break;
> > >   1058	
> > >   1059		case IP_VS_CONN_F_LOCALNODE:
> > > > 1060			cp->packet_xmit = ip_vs_null_xmit_v6;
> > 
> > 	We were not lucky this time. The original patch was trying to
> > patch ip_vs_bind_xmit_v6() but due to the similar code in 
> > ip_vs_bind_xmit() the change after applying occured in the IPv4 function
> > which comes first.
> > 
> > 	Pablo, can some manual applying solve this or we should modify
> > somehow this hunk to not match early in the file ? In this form it
> > will do the same problem on the next tree.
> 
> 	I hopefully solved this problem by reordering some code
> for better speed, just posted v4.

Thanks a lot Julian for the quick reply.