public inbox for oe-kbuild@lists.linux.dev
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: kernel/trace/trace.c:6382:27-28: ERROR: invalid reference to the index variable of the iterator on line 6308
Date: Tue, 31 Mar 2026 09:52:47 +0800	[thread overview]
Message-ID: <202603310916.clDNuApf-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Steven Rostedt <rostedt@goodmis.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d0c3bcd5b8976159d835a897254048e078f447e6
commit: 428add559b6923f13acc591913cda3467be98dfd tracing: Have tracer option be instance specific
date:   5 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 5 months ago
config: um-randconfig-r061-20260331 (https://download.01.org/0day-ci/archive/20260331/202603310916.clDNuApf-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202603310916.clDNuApf-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> kernel/trace/trace.c:6382:27-28: ERROR: invalid reference to the index variable of the iterator on line 6308
   kernel/trace/trace.c:6382:40-41: ERROR: invalid reference to the index variable of the iterator on line 6308

vim +6382 kernel/trace/trace.c

ef9188bcc6ca1d Mark-PK Tsai             2022-04-26  6286  
9c5b9d3d65e485 Masami Hiramatsu         2020-01-11  6287  int tracing_set_tracer(struct trace_array *tr, const char *buf)
09d23a1d8a82e8 Steven Rostedt (Red Hat  2015-02-03  6288) {
428add559b6923 Steven Rostedt           2025-11-11  6289  	struct tracer *trace = NULL;
428add559b6923 Steven Rostedt           2025-11-11  6290  	struct tracers *t;
12883efb670c28 Steven Rostedt (Red Hat  2013-03-05  6291) #ifdef CONFIG_TRACER_MAX_TRACE
34600f0e9c33c9 Steven Rostedt           2013-01-22  6292  	bool had_max_tr;
12883efb670c28 Steven Rostedt (Red Hat  2013-03-05  6293) #endif
d33b10c0c73adc Steven Rostedt           2024-12-24  6294  	int ret;
bc0c38d139ec7f Steven Rostedt           2008-05-12  6295  
d33b10c0c73adc Steven Rostedt           2024-12-24  6296  	guard(mutex)(&trace_types_lock);
1027fcb206a0fb Steven Rostedt           2009-03-12  6297  
7a1d1e4b9639ff Steven Rostedt (Google   2024-06-12  6298) 	update_last_data(tr);
7a1d1e4b9639ff Steven Rostedt (Google   2024-06-12  6299) 
a1f157c7a3bb34 Zheng Yejian             2023-09-06  6300  	if (!tr->ring_buffer_expanded) {
2b6080f28c7cc3 Steven Rostedt           2012-05-11  6301  		ret = __tracing_resize_ring_buffer(tr, trace_buf_size,
438ced1720b584 Vaibhav Nagarnaik        2012-02-02  6302  						RING_BUFFER_ALL_CPUS);
73c5162aa362a5 Steven Rostedt           2009-03-11  6303  		if (ret < 0)
d33b10c0c73adc Steven Rostedt           2024-12-24  6304  			return ret;
73c5162aa362a5 Steven Rostedt           2009-03-11  6305  		ret = 0;
73c5162aa362a5 Steven Rostedt           2009-03-11  6306  	}
73c5162aa362a5 Steven Rostedt           2009-03-11  6307  
428add559b6923 Steven Rostedt           2025-11-11 @6308  	list_for_each_entry(t, &tr->tracers, list) {
428add559b6923 Steven Rostedt           2025-11-11  6309  		if (strcmp(t->tracer->name, buf) == 0) {
428add559b6923 Steven Rostedt           2025-11-11  6310  			trace = t->tracer;
bc0c38d139ec7f Steven Rostedt           2008-05-12  6311  			break;
bc0c38d139ec7f Steven Rostedt           2008-05-12  6312  		}
428add559b6923 Steven Rostedt           2025-11-11  6313  	}
428add559b6923 Steven Rostedt           2025-11-11  6314  	if (!trace)
d33b10c0c73adc Steven Rostedt           2024-12-24  6315  		return -EINVAL;
d33b10c0c73adc Steven Rostedt           2024-12-24  6316  
428add559b6923 Steven Rostedt           2025-11-11  6317  	if (trace == tr->current_trace)
d33b10c0c73adc Steven Rostedt           2024-12-24  6318  		return 0;
bc0c38d139ec7f Steven Rostedt           2008-05-12  6319  
a35873a0993b4d Tom Zanussi              2019-02-13  6320  #ifdef CONFIG_TRACER_SNAPSHOT
428add559b6923 Steven Rostedt           2025-11-11  6321  	if (trace->use_max_tr) {
c0a581d7126c0b Waiman Long              2022-09-22  6322  		local_irq_disable();
a35873a0993b4d Tom Zanussi              2019-02-13  6323  		arch_spin_lock(&tr->max_lock);
22bec11a569983 Steven Rostedt           2025-01-06  6324  		ret = tr->cond_snapshot ? -EBUSY : 0;
a35873a0993b4d Tom Zanussi              2019-02-13  6325  		arch_spin_unlock(&tr->max_lock);
c0a581d7126c0b Waiman Long              2022-09-22  6326  		local_irq_enable();
a35873a0993b4d Tom Zanussi              2019-02-13  6327  		if (ret)
d33b10c0c73adc Steven Rostedt           2024-12-24  6328  			return ret;
a35873a0993b4d Tom Zanussi              2019-02-13  6329  	}
a35873a0993b4d Tom Zanussi              2019-02-13  6330  #endif
c7b3ae0bd2ca65 Ziqian SUN (Zamir        2017-09-11  6331) 	/* Some tracers won't work on kernel command line */
428add559b6923 Steven Rostedt           2025-11-11  6332  	if (system_state < SYSTEM_RUNNING && trace->noboot) {
c7b3ae0bd2ca65 Ziqian SUN (Zamir        2017-09-11  6333) 		pr_warn("Tracer '%s' is not allowed on command line, ignored\n",
428add559b6923 Steven Rostedt           2025-11-11  6334  			trace->name);
d1e27ee9c6f21c Steven Rostedt           2024-12-19  6335  		return -EINVAL;
c7b3ae0bd2ca65 Ziqian SUN (Zamir        2017-09-11  6336) 	}
c7b3ae0bd2ca65 Ziqian SUN (Zamir        2017-09-11  6337) 
607e2ea167e56d Steven Rostedt (Red Hat  2013-11-06  6338) 	/* Some tracers are only allowed for the top level buffer */
428add559b6923 Steven Rostedt           2025-11-11  6339  	if (!trace_ok_for_array(trace, tr))
d33b10c0c73adc Steven Rostedt           2024-12-24  6340  		return -EINVAL;
607e2ea167e56d Steven Rostedt (Red Hat  2013-11-06  6341) 
cf6ab6d9143b15 Steven Rostedt (Red Hat  2014-12-15  6342) 	/* If trace pipe files are being read, we can't change the tracer */
d33b10c0c73adc Steven Rostedt           2024-12-24  6343  	if (tr->trace_ref)
d33b10c0c73adc Steven Rostedt           2024-12-24  6344  		return -EBUSY;
cf6ab6d9143b15 Steven Rostedt (Red Hat  2014-12-15  6345) 
9f029e83e968e5 Steven Rostedt           2008-11-12  6346  	trace_branch_disable();
613f04a0f51e6e Steven Rostedt (Red Hat  2013-03-14  6347) 
50512ab576e1ce Steven Rostedt (Red Hat  2014-01-14  6348) 	tr->current_trace->enabled--;
613f04a0f51e6e Steven Rostedt (Red Hat  2013-03-14  6349) 
2b6080f28c7cc3 Steven Rostedt           2012-05-11  6350  	if (tr->current_trace->reset)
2b6080f28c7cc3 Steven Rostedt           2012-05-11  6351  		tr->current_trace->reset(tr);
613f04a0f51e6e Steven Rostedt (Red Hat  2013-03-14  6352) 
a541a9559bb0a8 Steven Rostedt (Google   2022-10-05  6353) #ifdef CONFIG_TRACER_MAX_TRACE
a541a9559bb0a8 Steven Rostedt (Google   2022-10-05  6354) 	had_max_tr = tr->current_trace->use_max_tr;
a541a9559bb0a8 Steven Rostedt (Google   2022-10-05  6355) 
7440172974e85b Paul E. McKenney         2018-11-06  6356  	/* Current trace needs to be nop_trace before synchronize_rcu */
2b6080f28c7cc3 Steven Rostedt           2012-05-11  6357  	tr->current_trace = &nop_trace;
428add559b6923 Steven Rostedt           2025-11-11  6358  	tr->current_trace_flags = nop_trace.flags;
34600f0e9c33c9 Steven Rostedt           2013-01-22  6359  
428add559b6923 Steven Rostedt           2025-11-11  6360  	if (had_max_tr && !trace->use_max_tr) {
34600f0e9c33c9 Steven Rostedt           2013-01-22  6361  		/*
34600f0e9c33c9 Steven Rostedt           2013-01-22  6362  		 * We need to make sure that the update_max_tr sees that
34600f0e9c33c9 Steven Rostedt           2013-01-22  6363  		 * current_trace changed to nop_trace to keep it from
34600f0e9c33c9 Steven Rostedt           2013-01-22  6364  		 * swapping the buffers after we resize it.
34600f0e9c33c9 Steven Rostedt           2013-01-22  6365  		 * The update_max_tr is called from interrupts disabled
34600f0e9c33c9 Steven Rostedt           2013-01-22  6366  		 * so a synchronized_sched() is sufficient.
34600f0e9c33c9 Steven Rostedt           2013-01-22  6367  		 */
7440172974e85b Paul E. McKenney         2018-11-06  6368  		synchronize_rcu();
3209cff4490bee Steven Rostedt (Red Hat  2013-03-12  6369) 		free_snapshot(tr);
180e4e390978af Vincent Donnefort        2024-02-20  6370  		tracing_disarm_snapshot(tr);
ef710e100c1068 KOSAKI Motohiro          2010-07-01  6371  	}
12883efb670c28 Steven Rostedt (Red Hat  2013-03-05  6372) 
428add559b6923 Steven Rostedt           2025-11-11  6373  	if (!had_max_tr && trace->use_max_tr) {
180e4e390978af Vincent Donnefort        2024-02-20  6374  		ret = tracing_arm_snapshot_locked(tr);
180e4e390978af Vincent Donnefort        2024-02-20  6375  		if (ret)
d33b10c0c73adc Steven Rostedt           2024-12-24  6376  			return ret;
ef710e100c1068 KOSAKI Motohiro          2010-07-01  6377  	}
a541a9559bb0a8 Steven Rostedt (Google   2022-10-05  6378) #else
a541a9559bb0a8 Steven Rostedt (Google   2022-10-05  6379) 	tr->current_trace = &nop_trace;
12883efb670c28 Steven Rostedt (Red Hat  2013-03-05  6380) #endif
577b785f55168d Steven Rostedt           2009-02-26  6381  
428add559b6923 Steven Rostedt           2025-11-11 @6382  	tr->current_trace_flags = t->flags ? : t->tracer->flags;
428add559b6923 Steven Rostedt           2025-11-11  6383  
428add559b6923 Steven Rostedt           2025-11-11  6384  	if (trace->init) {
428add559b6923 Steven Rostedt           2025-11-11  6385  		ret = tracer_init(trace, tr);
180e4e390978af Vincent Donnefort        2024-02-20  6386  		if (ret) {
180e4e390978af Vincent Donnefort        2024-02-20  6387  #ifdef CONFIG_TRACER_MAX_TRACE
428add559b6923 Steven Rostedt           2025-11-11  6388  			if (trace->use_max_tr)
180e4e390978af Vincent Donnefort        2024-02-20  6389  				tracing_disarm_snapshot(tr);
180e4e390978af Vincent Donnefort        2024-02-20  6390  #endif
428add559b6923 Steven Rostedt           2025-11-11  6391  			tr->current_trace_flags = nop_trace.flags;
d33b10c0c73adc Steven Rostedt           2024-12-24  6392  			return ret;
1c80025a49855b Frederic Weisbecker      2008-11-16  6393  		}
180e4e390978af Vincent Donnefort        2024-02-20  6394  	}
bc0c38d139ec7f Steven Rostedt           2008-05-12  6395  
428add559b6923 Steven Rostedt           2025-11-11  6396  	tr->current_trace = trace;
50512ab576e1ce Steven Rostedt (Red Hat  2014-01-14  6397) 	tr->current_trace->enabled++;
9f029e83e968e5 Steven Rostedt           2008-11-12  6398  	trace_branch_enable(tr);
bc0c38d139ec7f Steven Rostedt           2008-05-12  6399  
d33b10c0c73adc Steven Rostedt           2024-12-24  6400  	return 0;
d9e540762f5cdd Peter Zijlstra           2008-11-01  6401  }
d9e540762f5cdd Peter Zijlstra           2008-11-01  6402  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-03-31  1:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202603310916.clDNuApf-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox