From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1210 isst_if_get_perf_level_fabric_info() warn: potential spectre issue 'power_domain_info->perf_levels' [r] (local cap)
Date: Sat, 11 Apr 2026 07:33:33 +0800 [thread overview]
Message-ID: <202604110726.zQnOKLLP-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7c6c4ed80b874f721bc7c2c937e098c56e37d2f0
commit: d6644d737bec473a38dbd44a71553cacd636a920 platform/x86: ISST: Support SST-PP revision 2
date: 11 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 11 months ago
config: x86_64-randconfig-161-20260411 (https://download.01.org/0day-ci/archive/20260411/202604110726.zQnOKLLP-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: d6644d737bec ("platform/x86: ISST: Support SST-PP revision 2")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202604110726.zQnOKLLP-lkp@intel.com/
New smatch warnings:
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1210 isst_if_get_perf_level_fabric_info() warn: potential spectre issue 'power_domain_info->perf_levels' [r] (local cap)
Old smatch warnings:
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:747 isst_if_clos_assoc() warn: potential spectre issue 'sst_inst->power_domain_info[part]' [r] (local cap)
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1100 isst_if_get_perf_level_info() warn: potential spectre issue 'power_domain_info->perf_levels' [r] (local cap)
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1255 isst_if_get_perf_level_mask() warn: potential spectre issue 'power_domain_info->perf_levels' [r]
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1300 isst_if_get_base_freq_info() warn: potential spectre issue 'power_domain_info->perf_levels' [r] (local cap)
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1336 isst_if_get_base_freq_mask() warn: potential spectre issue 'power_domain_info->perf_levels' [r]
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1435 isst_if_get_turbo_freq_info() warn: potential spectre issue 'power_domain_info->perf_levels' [r] (local cap)
vim +1210 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
ea009e4769fa3b Srinivas Pandruvada 2023-03-07 1179
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1180 static int isst_if_get_perf_level_fabric_info(void __user *argp)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1181 {
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1182 struct isst_perf_level_fabric_info perf_level_fabric;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1183 struct tpmi_per_power_domain_info *power_domain_info;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1184 int start = SST_PP_CORE_RATIO_P0_FABRIC_START;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1185 int width = SST_PP_CORE_RATIO_P0_FABRIC_WIDTH;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1186 int offset = SST_PP_INFO_11_OFFSET;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1187 int i;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1188
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1189 if (copy_from_user(&perf_level_fabric, argp, sizeof(perf_level_fabric)))
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1190 return -EFAULT;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1191
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1192 power_domain_info = get_instance(perf_level_fabric.socket_id,
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1193 perf_level_fabric.power_domain_id);
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1194 if (!power_domain_info)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1195 return -EINVAL;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1196
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1197 if (perf_level_fabric.level > power_domain_info->max_level)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1198 return -EINVAL;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1199
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1200 if (power_domain_info->pp_header.feature_rev < 2)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1201 return -EINVAL;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1202
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1203 if (!(power_domain_info->pp_header.level_en_mask & BIT(perf_level_fabric.level)))
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1204 return -EINVAL;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1205
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1206 /* For revision 2, maximum number of fabrics is 2 */
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1207 perf_level_fabric.max_fabrics = 2;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1208
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1209 for (i = 0; i < perf_level_fabric.max_fabrics; i++) {
d6644d737bec47 Srinivas Pandruvada 2025-05-06 @1210 _read_pp_level_info("p0_fabric_freq_mhz", perf_level_fabric.p0_fabric_freq_mhz[i],
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1211 perf_level_fabric.level, offset, start, width,
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1212 SST_MUL_FACTOR_FREQ)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1213 start += width;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1214
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1215 _read_pp_level_info("p1_fabric_freq_mhz", perf_level_fabric.p1_fabric_freq_mhz[i],
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1216 perf_level_fabric.level, offset, start, width,
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1217 SST_MUL_FACTOR_FREQ)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1218 start += width;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1219
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1220 _read_pp_level_info("pm_fabric_freq_mhz", perf_level_fabric.pm_fabric_freq_mhz[i],
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1221 perf_level_fabric.level, offset, start, width,
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1222 SST_MUL_FACTOR_FREQ)
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1223 offset = SST_PP_INFO_12_OFFSET;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1224 start = SST_PP_CORE_RATIO_P0_FABRIC_1_START;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1225 }
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1226
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1227 if (copy_to_user(argp, &perf_level_fabric, sizeof(perf_level_fabric)))
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1228 return -EFAULT;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1229
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1230 return 0;
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1231 }
d6644d737bec47 Srinivas Pandruvada 2025-05-06 1232
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-04-10 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 23:33 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-29 2:26 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1210 isst_if_get_perf_level_fabric_info() warn: potential spectre issue 'power_domain_info->perf_levels' [r] (local cap) kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604110726.zQnOKLLP-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox