From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF7D31E827 for ; Sun, 24 May 2026 20:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779656130; cv=none; b=X7iAEevzJAaYlPdnRSk9gZQ6rJ/IEO6uPaa5hOQFYldHeikZ2ZchVz10mpl8X2swz7rQJQl/Ywfb6W5dQm2AJZpBJpxim7QFpYBJ0QsFdqQ1CQ8oIA2UuOBWlPSlu4FogOlmiB3JOtYkEmEl0S+BSy1U7xJS0Kt5Vk9e1muh7WE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779656130; c=relaxed/simple; bh=WwLlBP4agKQXb3Meg86VgpEw+ry4ZfWajfeClH2+3Xo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=aljvxWIxSuYoDJA96QfUIfpkvJ5aLOUrXsnxOmNDkoAW6zASKgcuoYbqZH48PryrCGGEW2rSyUG1VVIalouo0xeQ6hJ9n5kuQ5eNDxKLCoKWfv7kk6MvFBL6aU8kMsmD0LXnUbZFEaknmn/42OtPwdggnKTU9WoJdzsGljfy4iA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oFFxad4t; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oFFxad4t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779656126; x=1811192126; h=date:from:to:cc:subject:message-id:mime-version: content-transfer-encoding; bh=WwLlBP4agKQXb3Meg86VgpEw+ry4ZfWajfeClH2+3Xo=; b=oFFxad4tKdBgyEP74xQSftATY9ZmCzl1E0z/se+HfqvJwG6JzbbXALkX OczPnyGFcXxF//ov6CGedAvvgPkhrxNQ17VwEQgTgcDfO3wav6XMjN8gc yBfwGLgTWTyjIlP7LdWuF++fFTcEThloD/yeoFrWc0AxO0hvto1hh5umb L3uD/5Wmo6oOt+ygjIOohMnGvhafhMMOPy+hszBHQ5H56BGRujrLR+ktY lRWLlKO1LxqnUe7+wqlX5CWUphyvpR2uuQD7WMSnJ5GdjJGiA+ymetDCB qyWu3QL/93DFE4FrrusVkeBPGRcdAaUs5QTqLr+DBHceV3igAYDqdC74u g==; X-CSE-ConnectionGUID: mPm1V+ULRs22NQ7wr6olaw== X-CSE-MsgGUID: vuPcXkNGQMuStU583UkSdA== X-IronPort-AV: E=McAfee;i="6800,10657,11796"; a="83066728" X-IronPort-AV: E=Sophos;i="6.24,166,1774335600"; d="scan'208";a="83066728" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2026 13:55:23 -0700 X-CSE-ConnectionGUID: iIl1Iz+VSQu4+m/Kyv0KZQ== X-CSE-MsgGUID: VtjuI/VsQWuL3QSuPK0/Zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,166,1774335600"; d="scan'208";a="245699757" Received: from lkp-server01.sh.intel.com (HELO f0d55cb201f0) ([10.239.97.150]) by orviesa004.jf.intel.com with ESMTP; 24 May 2026 13:55:21 -0700 Received: from kbuild by f0d55cb201f0 with local (Exim 4.98.2) (envelope-from ) id 1wRFqx-000000000a7-0L9y; Sun, 24 May 2026 20:55:19 +0000 Date: Mon, 25 May 2026 04:54:56 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/platform/x86/toshiba_bluetooth.c:261 toshiba_bt_rfkill_probe() warn: 'bt_dev->rfk' is an error pointer or valid Message-ID: <202605250449.XRHrnanj-lkp@intel.com> User-Agent: s-nail v14.9.25 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: "Rafael J. Wysocki" CC: "Ilpo J=C3=A4rvinen" tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 6a97c4d5262d02f04d1f41113b0d090ea51f08dd commit: 553b2ac59fbb434330287fde0cabc64bc6f11ceb platform/x86: toshiba_blue= tooth: Convert ACPI driver to a platform one date: 8 weeks ago :::::: branch date: 63 minutes ago :::::: commit date: 8 weeks ago config: x86_64-randconfig-r072-20260524 (https://download.01.org/0day-ci/ar= chive/20260525/202605250449.XRHrnanj-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f022= 7cb60147a26a1eeb4fb06e3b505e9c7261) rustc: rustc 1.88.0 (6b00bc388 2025-06-23) smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new versio= n of the same patch/commit), kindly add following tags | Fixes: 553b2ac59fbb ("platform/x86: toshiba_bluetooth: Convert ACPI drive= r to a platform one") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202605250449.XRHrnanj-lkp@intel.com/ smatch warnings: drivers/platform/x86/toshiba_bluetooth.c:261 toshiba_bt_rfkill_probe() warn= : 'bt_dev->rfk' is an error pointer or valid vim +261 drivers/platform/x86/toshiba_bluetooth.c 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 230 =20 553b2ac59fbb43 Rafael J. Wysocki 2026-03-24 231 static int toshiba_bt_rfk= ill_probe(struct platform_device *pdev) 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 232 { 553b2ac59fbb43 Rafael J. Wysocki 2026-03-24 233 struct acpi_device *devi= ce =3D ACPI_COMPANION(&pdev->dev); 84c0691e514539 Azael Avalos 2015-05-03 234 struct toshiba_bluetooth= _dev *bt_dev; 18b8696b66d790 Azael Avalos 2015-03-26 235 int result; 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 236 =20 18b8696b66d790 Azael Avalos 2015-03-26 237 result =3D toshiba_bluet= ooth_present(device->handle); 18b8696b66d790 Azael Avalos 2015-03-26 238 if (result) 18b8696b66d790 Azael Avalos 2015-03-26 239 return result; 18b8696b66d790 Azael Avalos 2015-03-26 240 =20 18b8696b66d790 Azael Avalos 2015-03-26 241 pr_info("Toshiba ACPI Bl= uetooth device driver\n"); 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 242 =20 bf4afc53b77aea Linus Torvalds 2026-02-21 243 bt_dev =3D kzalloc_obj(*= bt_dev); 84c0691e514539 Azael Avalos 2015-05-03 244 if (!bt_dev) 84c0691e514539 Azael Avalos 2015-05-03 245 return -ENOMEM; 84c0691e514539 Azael Avalos 2015-05-03 246 bt_dev->acpi_dev =3D dev= ice; 553b2ac59fbb43 Rafael J. Wysocki 2026-03-24 247 =20 553b2ac59fbb43 Rafael J. Wysocki 2026-03-24 248 platform_set_drvdata(pde= v, bt_dev); 84c0691e514539 Azael Avalos 2015-05-03 249 =20 84c0691e514539 Azael Avalos 2015-05-03 250 result =3D toshiba_bluet= ooth_sync_status(bt_dev); 84c0691e514539 Azael Avalos 2015-05-03 251 if (result) { 84c0691e514539 Azael Avalos 2015-05-03 252 kfree(bt_dev); 84c0691e514539 Azael Avalos 2015-05-03 253 return result; 84c0691e514539 Azael Avalos 2015-05-03 254 } 84c0691e514539 Azael Avalos 2015-05-03 255 =20 7ee8cd3319d5e5 Azael Avalos 2015-05-03 256 bt_dev->rfk =3D rfkill_a= lloc("Toshiba Bluetooth", 553b2ac59fbb43 Rafael J. Wysocki 2026-03-24 257 &pdev->dev, 7ee8cd3319d5e5 Azael Avalos 2015-05-03 258 RFKILL_TYPE_BLUETO= OTH, 7ee8cd3319d5e5 Azael Avalos 2015-05-03 259 &rfk_ops, 7ee8cd3319d5e5 Azael Avalos 2015-05-03 260 bt_dev); 7ee8cd3319d5e5 Azael Avalos 2015-05-03 @261 if (!bt_dev->rfk) { 7ee8cd3319d5e5 Azael Avalos 2015-05-03 262 pr_err("Unable to alloc= ate rfkill device\n"); 4315abf3383010 Rafael J. Wysocki 2026-03-24 263 result =3D -ENOMEM; 4315abf3383010 Rafael J. Wysocki 2026-03-24 264 goto err_free_bt_dev; 7ee8cd3319d5e5 Azael Avalos 2015-05-03 265 } 7ee8cd3319d5e5 Azael Avalos 2015-05-03 266 =20 7ee8cd3319d5e5 Azael Avalos 2015-05-03 267 rfkill_set_hw_state(bt_d= ev->rfk, !bt_dev->killswitch); 7ee8cd3319d5e5 Azael Avalos 2015-05-03 268 =20 7ee8cd3319d5e5 Azael Avalos 2015-05-03 269 result =3D rfkill_regist= er(bt_dev->rfk); 7ee8cd3319d5e5 Azael Avalos 2015-05-03 270 if (result) { 7ee8cd3319d5e5 Azael Avalos 2015-05-03 271 pr_err("Unable to regis= ter rfkill device\n"); 4315abf3383010 Rafael J. Wysocki 2026-03-24 272 goto err_rfkill_destroy; 7ee8cd3319d5e5 Azael Avalos 2015-05-03 273 } 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 274 =20 4315abf3383010 Rafael J. Wysocki 2026-03-24 275 result =3D acpi_dev_inst= all_notify_handler(device, ACPI_DEVICE_NOTIFY, 4315abf3383010 Rafael J. Wysocki 2026-03-24 276 toshiba_bt_rfkill_= notify, bt_dev); 4315abf3383010 Rafael J. Wysocki 2026-03-24 277 if (result) { 4315abf3383010 Rafael J. Wysocki 2026-03-24 278 pr_err("Unable to regis= ter ACPI notify handler\n"); 4315abf3383010 Rafael J. Wysocki 2026-03-24 279 goto err_rfkill_unregis= ter; 4315abf3383010 Rafael J. Wysocki 2026-03-24 280 } 4315abf3383010 Rafael J. Wysocki 2026-03-24 281 =20 4315abf3383010 Rafael J. Wysocki 2026-03-24 282 return 0; 4315abf3383010 Rafael J. Wysocki 2026-03-24 283 =20 4315abf3383010 Rafael J. Wysocki 2026-03-24 284 err_rfkill_unregister: 4315abf3383010 Rafael J. Wysocki 2026-03-24 285 rfkill_unregister(bt_dev= ->rfk); 4315abf3383010 Rafael J. Wysocki 2026-03-24 286 err_rfkill_destroy: 4315abf3383010 Rafael J. Wysocki 2026-03-24 287 rfkill_destroy(bt_dev->r= fk); 4315abf3383010 Rafael J. Wysocki 2026-03-24 288 err_free_bt_dev: 4315abf3383010 Rafael J. Wysocki 2026-03-24 289 kfree(bt_dev); 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 290 return result; 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 291 } 42b4e9ee3d1d3b Jes Sorensen 2009-12-16 292 =20 :::::: The code at line 261 was first introduced by commit :::::: 7ee8cd3319d5e57b1b5e2b348f078af44e67a577 toshiba_bluetooth: Add RFKi= ll handler functions :::::: TO: Azael Avalos :::::: CC: Darren Hart -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki