0 day kernel build service
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/power/supply/max77759_charger.c:533:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Date: Sat, 06 Jun 2026 01:37:09 +0800	[thread overview]
Message-ID: <202606060122.MH7UDsNR-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Amit Sunil Dhamne <amitsd@google.com>
CC: "André Draszik" <andre.draszik@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ddd664bbff63e09e7a7f9acae9c43605d4cf185f
commit: 70d7dd27f6dc9bada652c3a84ba7e6688a96f8db power: supply: max77759: add charger driver
date:   10 weeks ago
:::::: branch date: 20 hours ago
:::::: commit date: 10 weeks ago
config: mips-randconfig-r063-20260604 (https://download.01.org/0day-ci/archive/20260606/202606060122.MH7UDsNR-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project e5ab4f8a1f766febdc65ce89c00dec85393cfd68)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 70d7dd27f6dc ("power: supply: max77759: add charger driver")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202606060122.MH7UDsNR-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/power/supply/max77759_charger.c:533:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)

vim +533 drivers/power/supply/max77759_charger.c

70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  504  
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  505  static int max77759_init_irqhandler(struct max77759_charger *chg)
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  506  {
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  507  	struct device *dev = chg->dev;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  508  	irq_handler_t thread_fn;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  509  	char *name;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  510  	int i, ret;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  511  
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  512  	for (i = 0; i < ARRAY_SIZE(chgr_irqs_str); i++) {
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  513  		ret = platform_get_irq_byname(to_platform_device(dev),
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  514  					      chgr_irqs_str[i]);
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  515  		if (ret < 0)
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  516  			return dev_err_probe(dev, ret,
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  517  					     "Failed to get irq resource for %s\n",
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  518  					     chgr_irqs_str[i]);
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  519  
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  520  		chg->irqs[i] = ret;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  521  		name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", dev_name(dev),
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  522  				      chgr_irqs_str[i]);
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  523  		if (!name)
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  524  			return dev_err_probe(dev, -ENOMEM,
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  525  					     "Failed to allocate space for irqname: %s\n",
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  526  					     chgr_irqs_str[i]);
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  527  
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  528  		if (i == BAT_OILO)
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  529  			thread_fn = bat_oilo_irq_handler;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  530  		else
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  531  			thread_fn = irq_handler;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  532  
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25 @533  		ret = devm_request_threaded_irq(dev, chg->irqs[i], NULL,
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  534  						thread_fn, 0, name, chg);
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  535  		if (ret)
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  536  			return dev_err_probe(dev, ret,
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  537  					     "Unable to register irq handler for %s\n",
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  538  					     chgr_irqs_str[i]);
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  539  	}
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  540  
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  541  	return 0;
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  542  }
70d7dd27f6dc9ba Amit Sunil Dhamne 2026-03-25  543  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2026-06-05 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05 17:37 kernel test robot [this message]
2026-07-23  0:58 ` drivers/power/supply/max77759_charger.c:533:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Amit Sunil Dhamne
  -- strict thread matches above, loose matches on Subject: below --
2026-07-22  6:34 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202606060122.MH7UDsNR-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox