0 day kernel build service
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: fs/nfs/blocklayout/blocklayout.c:110:3-22: opportunity for str_read_write(bio_op ( bio ) == READ)
Date: Tue, 25 Aug 2026 18:14:13 +0800	[thread overview]
Message-ID: <202608251849.dtCMZoXT-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Anna Schumaker <anna.schumaker@oracle.com>

Hi Anna,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0a0d1d55dad570724bf8c7ea83409639cfb4be9b
commit: 7537db24806fdc3d3ec4fef53babdc22c9219e75 NFS: Merge CONFIG_NFS_V4_1 with CONFIG_NFS_V4
date:   7 months ago
:::::: branch date: 32 hours ago
:::::: commit date: 7 months ago
config: i386-randconfig-052-20260825 (https://download.01.org/0day-ci/archive/20260825/202608251849.dtCMZoXT-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 7537db24806f ("NFS: Merge CONFIG_NFS_V4_1 with CONFIG_NFS_V4")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202608251849.dtCMZoXT-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/nfs/blocklayout/blocklayout.c:110:3-22: opportunity for str_read_write(bio_op ( bio ) == READ)

vim +110 fs/nfs/blocklayout/blocklayout.c

9549ec01b0dcf1c Fred Isaman     2011-07-30  103  
9549ec01b0dcf1c Fred Isaman     2011-07-30  104  static struct bio *
4e49ea4a3d27636 Mike Christie   2016-06-05  105  bl_submit_bio(struct bio *bio)
9549ec01b0dcf1c Fred Isaman     2011-07-30  106  {
9549ec01b0dcf1c Fred Isaman     2011-07-30  107  	if (bio) {
9549ec01b0dcf1c Fred Isaman     2011-07-30  108  		get_parallel(bio->bi_private);
9549ec01b0dcf1c Fred Isaman     2011-07-30  109  		dprintk("%s submitting %s bio %u@%llu\n", __func__,
95fe6c1a209ef89 Mike Christie   2016-06-05 @110  			bio_op(bio) == READ ? "read" : "write",
4e49ea4a3d27636 Mike Christie   2016-06-05  111  			bio->bi_iter.bi_size,
4f024f3797c43cb Kent Overstreet 2013-10-11  112  			(unsigned long long)bio->bi_iter.bi_sector);
4e49ea4a3d27636 Mike Christie   2016-06-05  113  		submit_bio(bio);
9549ec01b0dcf1c Fred Isaman     2011-07-30  114  	}
9549ec01b0dcf1c Fred Isaman     2011-07-30  115  	return NULL;
9549ec01b0dcf1c Fred Isaman     2011-07-30  116  }
9549ec01b0dcf1c Fred Isaman     2011-07-30  117  

:::::: The code at line 110 was first introduced by commit
:::::: 95fe6c1a209ef89d9f94dd04a0ad72be1487d5d5 block, fs, mm, drivers: use bio set/get op accessors

:::::: TO: Mike Christie <mchristi@redhat.com>
:::::: CC: Jens Axboe <axboe@fb.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-25 10:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608251849.dtCMZoXT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox