diff for duplicates of <202609010758.3N8tYZdG-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 3414089..baff89c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,15 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-kernel@vger.kernel.org -TO: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com> -CC: Miquel Raynal <miquel.raynal@bootlin.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cee9395acd8043be0644b25c34bfa86623f2b935 commit: 5c56bf214af85ca042bf97f8584aab2151035840 mtd: rawnand: cadence: fix DMA device NULL pointer dereference -date: 10 months ago -:::::: branch date: 27 hours ago -:::::: commit date: 10 months ago config: i386-randconfig-141-20260831 (https://download.01.org/0day-ci/archive/20260901/202609010758.3N8tYZdG-lkp@intel.com/config) compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211) smatch: v0.5.0-9187-g5189e3fb @@ -26,7 +17,6 @@ drivers/mtd/nand/raw/cadence-nand-controller.c:2956 cadence_nand_init() warn: va vim +2956 drivers/mtd/nand/raw/cadence-nand-controller.c -ec4ba01e894d31 Piotr Sroka 2019-09-26 2870 ec4ba01e894d31 Piotr Sroka 2019-09-26 2871 static int cadence_nand_init(struct cdns_nand_ctrl *cdns_ctrl) ec4ba01e894d31 Piotr Sroka 2019-09-26 2872 { ec4ba01e894d31 Piotr Sroka 2019-09-26 2873 dma_cap_mask_t mask; @@ -66,6 +56,9 @@ ec4ba01e894d31 Piotr Sroka 2019-09-26 2906 dma_cap_zero(mask); ec4ba01e894d31 Piotr Sroka 2019-09-26 2907 dma_cap_set(DMA_MEMCPY, mask); ec4ba01e894d31 Piotr Sroka 2019-09-26 2908 ec4ba01e894d31 Piotr Sroka 2019-09-26 2909 if (cdns_ctrl->caps1->has_dma) { + +If cdns_ctrl->caps1->has_dma is false + 2b9df00cded911 Niravkumar L Rabara 2025-02-10 2910 cdns_ctrl->dmac = dma_request_chan_by_mask(&mask); 2b9df00cded911 Niravkumar L Rabara 2025-02-10 2911 if (IS_ERR(cdns_ctrl->dmac)) { 2b9df00cded911 Niravkumar L Rabara 2025-02-10 2912 ret = dev_err_probe(cdns_ctrl->dev, PTR_ERR(cdns_ctrl->dmac), @@ -75,6 +68,9 @@ ec4ba01e894d31 Piotr Sroka 2019-09-26 2915 } ec4ba01e894d31 Piotr Sroka 2019-09-26 2916 } ec4ba01e894d31 Piotr Sroka 2019-09-26 2917 5c56bf214af85c Niravkumar L Rabara 2025-10-23 @2918 dma_dev = cdns_ctrl->dmac->device; + ^^^^^^^^^^^^^^^ +Then this is a NULL dereference. I reported this bug in March. + d76d22b5096c5b Niravkumar L Rabara 2025-02-10 2919 cdns_ctrl->io.iova_dma = dma_map_resource(dma_dev->dev, cdns_ctrl->io.dma, d76d22b5096c5b Niravkumar L Rabara 2025-02-10 2920 cdns_ctrl->io.size, d76d22b5096c5b Niravkumar L Rabara 2025-02-10 2921 DMA_BIDIRECTIONAL, 0); @@ -127,13 +123,6 @@ ec4ba01e894d31 Piotr Sroka 2019-09-26 2967 cdns_ctrl->cdma_desc, ec4ba01e894d31 Piotr Sroka 2019-09-26 2968 ec4ba01e894d31 Piotr Sroka 2019-09-26 2969 return ret; ec4ba01e894d31 Piotr Sroka 2019-09-26 2970 } -ec4ba01e894d31 Piotr Sroka 2019-09-26 2971 - -:::::: The code at line 2956 was first introduced by commit -:::::: ec4ba01e894d3165e4d1ccbef782ef5593b708b4 mtd: rawnand: Add new Cadence NAND driver to MTD subsystem - -:::::: TO: Piotr Sroka <piotrs@cadence.com> -:::::: CC: Miquel Raynal <miquel.raynal@bootlin.com> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 43160ec..b37ddb6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,23 +1,17 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0drivers/mtd/nand/raw/cadence-nand-controller.c:2956 cadence_nand_init() warn: variable dereferenced before check 'cdns_ctrl->dmac' (see line 2918)\0" - "Date\0Tue, 01 Sep 2026 07:10:19 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 9 Sep 2026 14:36:06 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-kernel@vger.kernel.org + " Miquel Raynal <miquel.raynal@bootlin.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-kernel@vger.kernel.org\n" - "TO: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>\n" - "CC: Miquel Raynal <miquel.raynal@bootlin.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: cee9395acd8043be0644b25c34bfa86623f2b935\n" "commit: 5c56bf214af85ca042bf97f8584aab2151035840 mtd: rawnand: cadence: fix DMA device NULL pointer dereference\n" - "date: 10 months ago\n" - ":::::: branch date: 27 hours ago\n" - ":::::: commit date: 10 months ago\n" "config: i386-randconfig-141-20260831 (https://download.01.org/0day-ci/archive/20260901/202609010758.3N8tYZdG-lkp@intel.com/config)\n" "compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -34,7 +28,6 @@ "\n" "vim +2956 drivers/mtd/nand/raw/cadence-nand-controller.c\n" "\n" - "ec4ba01e894d31 Piotr Sroka 2019-09-26 2870 \n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2871 static int cadence_nand_init(struct cdns_nand_ctrl *cdns_ctrl)\n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2872 {\n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2873 \tdma_cap_mask_t mask;\n" @@ -74,6 +67,9 @@ "ec4ba01e894d31 Piotr Sroka 2019-09-26 2907 \tdma_cap_set(DMA_MEMCPY, mask);\n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2908 \n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2909 \tif (cdns_ctrl->caps1->has_dma) {\n" + "\n" + "If cdns_ctrl->caps1->has_dma is false\n" + "\n" "2b9df00cded911 Niravkumar L Rabara 2025-02-10 2910 \t\tcdns_ctrl->dmac = dma_request_chan_by_mask(&mask);\n" "2b9df00cded911 Niravkumar L Rabara 2025-02-10 2911 \t\tif (IS_ERR(cdns_ctrl->dmac)) {\n" "2b9df00cded911 Niravkumar L Rabara 2025-02-10 2912 \t\t\tret = dev_err_probe(cdns_ctrl->dev, PTR_ERR(cdns_ctrl->dmac),\n" @@ -83,6 +79,9 @@ "ec4ba01e894d31 Piotr Sroka 2019-09-26 2916 \t}\n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2917 \n" "5c56bf214af85c Niravkumar L Rabara 2025-10-23 @2918 \tdma_dev = cdns_ctrl->dmac->device;\n" + " ^^^^^^^^^^^^^^^\n" + "Then this is a NULL dereference. I reported this bug in March.\n" + "\n" "d76d22b5096c5b Niravkumar L Rabara 2025-02-10 2919 \tcdns_ctrl->io.iova_dma = dma_map_resource(dma_dev->dev, cdns_ctrl->io.dma,\n" "d76d22b5096c5b Niravkumar L Rabara 2025-02-10 2920 \t\t\t\t\t\t cdns_ctrl->io.size,\n" "d76d22b5096c5b Niravkumar L Rabara 2025-02-10 2921 \t\t\t\t\t\t DMA_BIDIRECTIONAL, 0);\n" @@ -135,16 +134,9 @@ "ec4ba01e894d31 Piotr Sroka 2019-09-26 2968 \n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2969 \treturn ret;\n" "ec4ba01e894d31 Piotr Sroka 2019-09-26 2970 }\n" - "ec4ba01e894d31 Piotr Sroka 2019-09-26 2971 \n" - "\n" - ":::::: The code at line 2956 was first introduced by commit\n" - ":::::: ec4ba01e894d3165e4d1ccbef782ef5593b708b4 mtd: rawnand: Add new Cadence NAND driver to MTD subsystem\n" - "\n" - ":::::: TO: Piotr Sroka <piotrs@cadence.com>\n" - ":::::: CC: Miquel Raynal <miquel.raynal@bootlin.com>\n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -b779785d962f0c4c4c3cbe041e75aa6cac0849adb5e28bfe5bd7d44c89dc54c1 +a7e9f23fe1e7c99c9816a5e2d5628d57697fa13ad7ec5445541b1c22bc664c24
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox