0 day kernel build service
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [android-common:android-mainline 12/12] drivers/clocksource/timer-pxa.c:174 pxa_timer_common_init() warn: 'irq' from request_irq() not released on lines: 168.
Date: Thu, 10 Sep 2026 18:48:08 +0800	[thread overview]
Message-ID: <202609101837.SNai98DF-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com

tree:   https://android.googlesource.com/kernel/common android-mainline
head:   c9692a371ad73c176aa0f66e06dddd0cec6c20f9
commit: 29df31ae3e8a0152dd8e8c2376816aad2f233473 [12/12] pinctrl: renesas: rzg2l: Add SR register cache for PM suspend/resume
:::::: branch date: 21 hours ago
:::::: commit date: 5 months ago
config: arm64-randconfig-r071-20260910 (https://download.01.org/0day-ci/archive/20260910/202609101837.SNai98DF-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 16.1.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 29df31ae3e8a ("pinctrl: renesas: rzg2l: Add SR register cache for PM suspend/resume")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609101837.SNai98DF-lkp@intel.com/

smatch warnings:
drivers/clocksource/timer-pxa.c:174 pxa_timer_common_init() warn: 'irq' from request_irq() not released on lines: 168.
drivers/clocksource/timer-pxa.c:208 pxa_timer_dt_init() warn: 'clk' from clk_prepare_enable() not released on lines: 205.

vim +/irq +174 drivers/clocksource/timer-pxa.c

^1da177e4c3f41 arch/arm/mach-pxa/time.c        Linus Torvalds 2005-04-16  145  
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  146  static int __init pxa_timer_common_init(int irq, unsigned long clock_tick_rate)
^1da177e4c3f41 arch/arm/mach-pxa/time.c        Linus Torvalds 2005-04-16  147  {
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  148  	int ret;
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  149  
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  150  	timer_writel(0, OIER);
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  151  	timer_writel(OSSR_M0 | OSSR_M1 | OSSR_M2 | OSSR_M3, OSSR);
c80204e5d67d14 arch/arm/mach-pxa/time.c        Sascha Hauer   2006-12-12  152  
364ed1e0ab019d arch/arm/mach-pxa/time.c        Stephen Boyd   2013-11-15  153  	sched_clock_register(pxa_read_sched_clock, 32, clock_tick_rate);
6c3a158316598b arch/arm/mach-pxa/time.c        Nicolas Pitre  2007-08-17  154  
320ab2b0b1e08e arch/arm/mach-pxa/time.c        Rusty Russell  2008-12-13  155  	ckevt_pxa_osmr0.cpumask = cpumask_of(0);
^1da177e4c3f41 arch/arm/mach-pxa/time.c        Linus Torvalds 2005-04-16  156  
cc2550b421aa30 drivers/clocksource/timer-pxa.c afzal mohammed 2020-02-27  157  	ret = request_irq(irq, pxa_ost0_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
cc2550b421aa30 drivers/clocksource/timer-pxa.c afzal mohammed 2020-02-27  158  			  "ost0", &ckevt_pxa_osmr0);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  159  	if (ret) {
ac9ce6d1a0cc29 drivers/clocksource/pxa_timer.c Rafał Miłecki  2017-03-09  160  		pr_err("Failed to setup irq\n");
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  161  		return ret;
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  162  	}
5c53ff088cb76d arch/arm/mach-pxa/time.c        Nicolas Pitre  2005-09-01  163  
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  164  	ret = clocksource_mmio_init(timer_base + OSCR, "oscr0", clock_tick_rate, 200,
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  165  				    32, clocksource_mmio_readl_up);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  166  	if (ret) {
ac9ce6d1a0cc29 drivers/clocksource/pxa_timer.c Rafał Miłecki  2017-03-09  167  		pr_err("Failed to init clocksource\n");
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  168  		return ret;
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  169  	}
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  170  
8d84981e395850 arch/arm/mach-pxa/time.c        Olof Johansson 2013-01-14  171  	clockevents_config_and_register(&ckevt_pxa_osmr0, clock_tick_rate,
8d84981e395850 arch/arm/mach-pxa/time.c        Olof Johansson 2013-01-14  172  					MIN_OSCR_DELTA * 2, 0x7fffffff);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  173  
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06 @174  	return 0;
5c53ff088cb76d arch/arm/mach-pxa/time.c        Nicolas Pitre  2005-09-01  175  }
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  176  
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  177  static int __init pxa_timer_dt_init(struct device_node *np)
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  178  {
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  179  	struct clk *clk;
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  180  	int irq, ret;
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  181  
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  182  	/* timer registers are shared with watchdog timer */
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  183  	timer_base = of_iomap(np, 0);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  184  	if (!timer_base) {
2a4849d2674b96 drivers/clocksource/pxa_timer.c Rob Herring    2018-08-27  185  		pr_err("%pOFn: unable to map resource\n", np);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  186  		return -ENXIO;
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  187  	}
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  188  
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  189  	clk = of_clk_get(np, 0);
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  190  	if (IS_ERR(clk)) {
2a4849d2674b96 drivers/clocksource/pxa_timer.c Rob Herring    2018-08-27  191  		pr_crit("%pOFn: unable to get clk\n", np);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  192  		return PTR_ERR(clk);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  193  	}
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  194  
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  195  	ret = clk_prepare_enable(clk);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  196  	if (ret) {
ac9ce6d1a0cc29 drivers/clocksource/pxa_timer.c Rafał Miłecki  2017-03-09  197  		pr_crit("Failed to prepare clock\n");
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  198  		return ret;
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  199  	}
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  200  
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  201  	/* we are only interested in OS-timer0 irq */
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  202  	irq = irq_of_parse_and_map(np, 0);
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  203  	if (irq <= 0) {
2a4849d2674b96 drivers/clocksource/pxa_timer.c Rob Herring    2018-08-27  204  		pr_crit("%pOFn: unable to parse OS-timer0 irq\n", np);
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06  205  		return -EINVAL;
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  206  	}
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  207  
be3aff842d646f drivers/clocksource/pxa_timer.c Daniel Lezcano 2016-06-06 @208  	return pxa_timer_common_init(irq, clk_get_rate(clk));
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  209  }
1727339590fdb5 drivers/clocksource/pxa_timer.c Daniel Lezcano 2017-05-26  210  TIMER_OF_DECLARE(pxa_timer, "marvell,pxa-timer", pxa_timer_dt_init);
ab5354c48d58a6 drivers/clocksource/pxa_timer.c Robert Jarzmik 2014-07-14  211  

:::::: The code at line 174 was first introduced by commit
:::::: be3aff842d646f64c1c82e3ee8a0ba14c0319a30 clocksource/drivers/pxa: Convert init function to return error

:::::: TO: Daniel Lezcano <daniel.lezcano@linaro.org>
:::::: CC: Daniel Lezcano <daniel.lezcano@linaro.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-10 10:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609101837.SNai98DF-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox