* [PATCH net-next v2 3/3] nfc: s3fwrn5: Change the error code [not found] <CGME20201117011850epcms2p568af074144630cd0f02b3a7f7eff8d1a@epcms2p5> @ 2020-11-17 1:18 ` Bongsu Jeon 2020-11-17 7:42 ` krzk 0 siblings, 1 reply; 3+ messages in thread From: Bongsu Jeon @ 2020-11-17 1:18 UTC (permalink / raw) To: linux-nfc [-- Attachment #1: Type: text/plain, Size: 1580 bytes --] ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> --- drivers/nfc/s3fwrn5/s3fwrn5.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h index 9d5f34759225..bb8f936d13a2 100644 --- a/drivers/nfc/s3fwrn5/s3fwrn5.h +++ b/drivers/nfc/s3fwrn5/s3fwrn5.h @@ -44,7 +44,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, enum s3fwrn5_mode mode) { if (!info->phy_ops->set_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_mode(info->phy_id, mode); @@ -54,7 +54,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) { if (!info->phy_ops->get_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->get_mode(info->phy_id); } @@ -62,7 +62,7 @@ static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) { if (!info->phy_ops->set_wake) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_wake(info->phy_id, wake); @@ -72,7 +72,7 @@ static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) static inline int s3fwrn5_write(struct s3fwrn5_info *info, struct sk_buff *skb) { if (!info->phy_ops->write) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->write(info->phy_id, skb); } -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2 3/3] nfc: s3fwrn5: Change the error code 2020-11-17 1:18 ` [PATCH net-next v2 3/3] nfc: s3fwrn5: Change the error code Bongsu Jeon @ 2020-11-17 7:42 ` krzk 0 siblings, 0 replies; 3+ messages in thread From: krzk @ 2020-11-17 7:42 UTC (permalink / raw) To: linux-nfc [-- Attachment #1: Type: text/plain, Size: 392 bytes --] On Tue, Nov 17, 2020 at 10:18:50AM +0900, Bongsu Jeon wrote: > ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > --- > drivers/nfc/s3fwrn5/s3fwrn5.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) I already reviewed it. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CGME20201117081137epcms2p84b5dd8d84ca608f44b0bb722b48f50b1@epcms2p8>]
* [PATCH net-next v2 3/3] nfc: s3fwrn5: Change the error code [not found] <CGME20201117081137epcms2p84b5dd8d84ca608f44b0bb722b48f50b1@epcms2p8> @ 2020-11-17 8:11 ` Bongsu Jeon 0 siblings, 0 replies; 3+ messages in thread From: Bongsu Jeon @ 2020-11-17 8:11 UTC (permalink / raw) To: linux-nfc [-- Attachment #1: Type: text/plain, Size: 1632 bytes --] ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> --- drivers/nfc/s3fwrn5/s3fwrn5.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h index 9d5f34759225..bb8f936d13a2 100644 --- a/drivers/nfc/s3fwrn5/s3fwrn5.h +++ b/drivers/nfc/s3fwrn5/s3fwrn5.h @@ -44,7 +44,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, enum s3fwrn5_mode mode) { if (!info->phy_ops->set_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_mode(info->phy_id, mode); @@ -54,7 +54,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) { if (!info->phy_ops->get_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->get_mode(info->phy_id); } @@ -62,7 +62,7 @@ static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) { if (!info->phy_ops->set_wake) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_wake(info->phy_id, wake); @@ -72,7 +72,7 @@ static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) static inline int s3fwrn5_write(struct s3fwrn5_info *info, struct sk_buff *skb) { if (!info->phy_ops->write) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->write(info->phy_id, skb); } -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-17 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20201117011850epcms2p568af074144630cd0f02b3a7f7eff8d1a@epcms2p5>
2020-11-17 1:18 ` [PATCH net-next v2 3/3] nfc: s3fwrn5: Change the error code Bongsu Jeon
2020-11-17 7:42 ` krzk
[not found] <CGME20201117081137epcms2p84b5dd8d84ca608f44b0bb722b48f50b1@epcms2p8>
2020-11-17 8:11 ` Bongsu Jeon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox