From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D424E47A0A1 for ; Wed, 13 May 2026 15:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778686362; cv=none; b=NzptmeElVl4afpjne1BlvAicdrw7iROjhxDOulpJw5vMmDKrCMECvtBod9S7uIMANJ9PWKk6HNM5go42IRPYKb/uHbu33/ohvcleNRXNML5TPDF4qcx+WuxPZB7e3RgOlxFe5aGuBmhg/QqJBcu9bcb91abUJ+QKuqzdmqO4uoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778686362; c=relaxed/simple; bh=uEdiX3bsYBq/wVfVqaY6nIE6JvVlmP8CjNL6fk0R+S8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ITmE7XaBwDOu0tFpq7/3leKZDQ0s6dVQWvN8AG/WsDKJdGOE0NOgBwd+0ztlGPCY6l/hcoEtsQI+gfb063tTchTxgSxZu0DOiRx1yi3g7duQRjde8QBKHroRiEMc6ArbF0a4ctnMbgiLqhvXamdlojANFiidFdupQvSIcwpzQnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BoQEkkJB; arc=none smtp.client-ip=209.85.216.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BoQEkkJB" Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-3680540a6efso2713514a91.2 for ; Wed, 13 May 2026 08:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778686360; x=1779291160; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2C8hObdO8WpevMDGMCA7yvRyBq1XyhuobSazR5gNIQs=; b=BoQEkkJBhTM+RNm4PH9SBiRQgvQNqggVjdIpixHMhs6o9cTu0RkoDIGBzdWF102Cdu v6lpRo2LAXPd5O8pFfDBoDsbNAkgpRNVSmgcyxTDN6Msh0PgnH4nWEAvNclSdSORXA5V zwd55iDu+vPJjy+qD+kEQfd0a3NkhW6bN3Lhm9ACxpxBTPDnVi0kuolKyA219UT0MweM jvd4yWKyDUUMYxyUByHrBrBz1hYpLqhxRB4sAP2gfhFclTthhsENlD1uXkhXtSA1njJk dOc/LC5BVmUgWufJqIdRu9uqErtUCUY1zD0vnQoyf5wCzGWfMlTyoCHIQRdMHAsptFkF LeSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778686360; x=1779291160; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2C8hObdO8WpevMDGMCA7yvRyBq1XyhuobSazR5gNIQs=; b=TXKMwqwUTJnGhQBwCy8SHn+9c33sj6uDD3bnMFh/fW9EAZ47Ky6hrCXRfTllpSgoHb Tc+WQhzn4s6u3eD/rNDC54eIIg+LPh6s3Tb3oo5tA/p58S2r2Bijq2cQD/rQhAeAVtHZ GxyFxgTfRnpo1Lc0WLxmdJbMGDoHZ0mc9HpFj+lhRByF83YVjPUNNlUs04SZD0ykKjhV M7adS5RBBwOPkYDh3x8aWEAQLTX53v+dEFpFL5g5Lj+drxMaMwLtkeZJ6osURASUUEzz KFSfAfRLlr76MjYr/H8tncsDGaGlXjBFVocEeWunbZ8soSUtLY2/364Sd/ciRn+AauH+ WPUA== X-Forwarded-Encrypted: i=1; AFNElJ+YcN92g8Ct9gioBhSi7DfKGdHUdmAx2mN8DSbFOLHUtcZQevNHCeOd0e839OMXLUbBhl24r7lP5IxQ46c=@lists.linux.dev X-Gm-Message-State: AOJu0Yx3n14qyFYJh4a8sBxey7I9InMocWH9uWI6EnfAaDRy/Rl5buqM UqpZN/wEscRnmE2q/K3xICVABovt+oJMnOfxAIvBaJfWTd732MxBqAw7 X-Gm-Gg: Acq92OGe0FYorG0Fywqc8dE0k75XrmHEPNNc9Yfeja7M4+sG+IAbNeRfuAi27A7kiz9 SxWplZ4/zsh9CwPo1+o3LUfogl4vF88Q627ZP1xeQBWm7jPVtiVTEavA5IZFxVBV5BDdrFqtr6F 4d1jUjlDjM8sfClV9r0xUvihiBjQr+pPs8yY/kVGFZeGjGNxGvP8nhoNNsKQaPvLhdA2Ii/TIbZ KbCeWyGRw04VE7f1C8b2pylGGivX5472HKLPXoy7x/4fu08UAk1d7aXLjvXyRdIBMMfz4Db2qFZ JoW3mpK0Ngz7p5raNKvsFuK8RQimRZlHVUQDJgmvyUtrjolIjlu1SCsMkdhK58N846xMyPuOjY0 RUgudZ4OaSVk2WP9mZeWPN7TvljdWMRORRVoMK7UmBwiMfo98AQ7mEJWyLHGqgY75yhokmS7v/H LZA7Dqqu265QZNSNcY X-Received: by 2002:a17:90a:c105:b0:368:5367:d681 with SMTP id 98e67ed59e1d1-368f782ef5amr3543149a91.10.1778686359919; Wed, 13 May 2026 08:32:39 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:54::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368ee6280d0sm3409228a91.16.2026.05.13.08.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 08:32:39 -0700 (PDT) Date: Wed, 13 May 2026 08:32:39 -0700 From: Stanislav Fomichev To: Breno Leitao Cc: Chas Williams <3chas3@gmail.com>, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Jon Maloy , Alexandra Winter , Thorsten Winkler , James Chapman , David Howells , Marc Dionne , David Heidelberg , Samuel Ortiz , linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-s390@vger.kernel.org, linux-afs@lists.infradead.org, oe-linux-nfc@lists.linux.dev, kernel-team@meta.com Subject: Re: [PATCH net-next 4/6] l2tp: ppp: convert to getsockopt_iter Message-ID: References: <20260513-getsock_four-v1-0-fe7f0e756fac@debian.org> <20260513-getsock_four-v1-4-fe7f0e756fac@debian.org> Precedence: bulk X-Mailing-List: oe-linux-nfc@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260513-getsock_four-v1-4-fe7f0e756fac@debian.org> On 05/13, Breno Leitao wrote: > Convert PPPoL2TP socket's getsockopt implementation to use the new > getsockopt_iter callback with sockopt_t. > > Key changes: > - Replace (char __user *optval, int __user *optlen) with sockopt_t *opt > - Use opt->optlen for buffer length (input) and returned size (output) > - Use copy_to_iter() instead of put_user()/copy_to_user() > > Signed-off-by: Breno Leitao > --- > net/l2tp/l2tp_ppp.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c > index 99d6582f41de2..4c7a1152b20ba 100644 > --- a/net/l2tp/l2tp_ppp.c > +++ b/net/l2tp/l2tp_ppp.c > @@ -59,6 +59,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1317,7 +1318,7 @@ static int pppol2tp_session_getsockopt(struct sock *sk, > * or the special tunnel type. > */ > static int pppol2tp_getsockopt(struct socket *sock, int level, int optname, > - char __user *optval, int __user *optlen) > + sockopt_t *opt) > { > struct sock *sk = sock->sk; > struct l2tp_session *session; > @@ -1328,9 +1329,7 @@ static int pppol2tp_getsockopt(struct socket *sock, int level, int optname, > if (level != SOL_PPPOL2TP) > return -EINVAL; > > - if (get_user(len, optlen)) > - return -EFAULT; > - > + len = opt->optlen; > if (len < 0) > return -EINVAL; > > @@ -1358,12 +1357,11 @@ static int pppol2tp_getsockopt(struct socket *sock, int level, int optname, > goto end_put_sess; > } > > - err = -EFAULT; > - if (put_user(len, optlen)) > - goto end_put_sess; > - > - if (copy_to_user((void __user *)optval, &val, len)) > + opt->optlen = len; > + if (copy_to_iter(&val, len, &opt->iter_out) != len) { > + err = -EFAULT; > goto end_put_sess; > + } > > err = 0; nit: if you're moving `err = -EFAULT`, you might as well remove this `err = 0` ? Acked-by: Stanislav Fomichev