Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: MNC/MCC as string?
Date: Fri, 12 Jun 2009 12:12:33 +0200	[thread overview]
Message-ID: <1244801553.8688.0.camel@violet> (raw)
In-Reply-To: <599a229656e82fa12be4d354525d7fbc@localhost>

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Hi Aki,

> Anyway, here it is. Please test; seems to work for me on my N95.

+static void extract_mcc_mnc(const char *str, char *mcc, char *mnc)
 {
-       int num = 0;
-       unsigned int i;
-
        /* Three digit country code */
-       for (i = 0; i < 3; i++)
-               num = num * 10 + (int)(str[i] - '0');
-
-       *mcc = num;
-
-       num = 0;
+       strncpy(mcc, str, sizeof(mcc));
+       mcc[3] = '\0';

maybe I am blind, but how is this suppose to work. The sizeof(mmc) is 1
byte.

Regards

Marcel



  reply	other threads:[~2009-06-12 10:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 11:26 MNC/MCC as string? Aki Niemi
2009-06-10 16:15 ` Denis Kenzior
2009-06-10 16:42   ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2009-06-10 17:41     ` Denis Kenzior
2009-06-11 11:46       ` Marcel Holtmann
2009-06-11 14:04         ` Jan Luebbe
2009-06-11 15:09           ` Marcel Holtmann
2009-06-11 14:32         ` Denis Kenzior
2009-06-11 15:12           ` Marcel Holtmann
2009-06-11 18:00           ` Aki Niemi
2009-06-11 18:10             ` Marcel Holtmann
2009-06-11 19:02               ` Aki Niemi
2009-06-11 19:18                 ` Marcel Holtmann
2009-06-11 19:38                   ` Aki Niemi
2009-06-11 20:08                     ` Denis Kenzior
2009-06-12 10:01                       ` Aki Niemi
2009-06-12 10:12                         ` Marcel Holtmann [this message]
2009-06-12 10:53                           ` Aki Niemi
2009-06-13  1:01                             ` Denis Kenzior
2009-06-12 10:56                           ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2009-06-11 19:58                   ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2009-06-11 20:33                     ` Marcel Holtmann
2009-06-11 20:35                 ` Marcel Holtmann
2009-06-11 18:24             ` Denis Kenzior
2009-06-11 18:10         ` Aki Niemi
2009-06-11  6:16   ` Aki Niemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244801553.8688.0.camel@violet \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox