From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] G1: move chat handling into enable callback
Date: Fri, 02 Oct 2009 04:46:53 +0200 [thread overview]
Message-ID: <1254451613.2659.119.camel@localhost.localdomain> (raw)
In-Reply-To: <20090929235359.2b3dffd7@mycelium.queued.net>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
Hi Andres,
> This updates the g1 code to create the GAtChat object in the enable() callback,
> and to unref it in the disable() callback. This is more in line with what
> the other plugins do, and as a bonus fixes a segfault when powering down
> the G1 modem..
>
> Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>
I see that Denis has applied this patch. In the future, please leave the
Signed-off-by lines out since we are not using them inside oFono. That
is more a kernel commit thing.
Regards
Marcel
prev parent reply other threads:[~2009-10-02 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 3:53 [PATCH] G1: move chat handling into enable callback Andres Salomon
2009-10-02 2:46 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254451613.2659.119.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox