Re: [PATCH] modemconf: default to grabbing the "Device" entry from the config file

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

Hi Andres,

> Previously, we manually listed every driver entry that needed Device;
> this meant that we needed to edit modemconf.c every time we added
> a new modem plugin.  Sjoerd Simons discovered that mbm doesn't work
> because it wasn't listed in modemconf, therefore Device was being
> ignored.  This patch makes modemconf default to setting Device, with
> exceptions made for certain plugin drivers.
> 
> A better way to fix this that I started working on would be to have
> each driver plugin have a table of desired/required strings, and to
> keep any knowledge of drivers out of udev.c and modemconf.c.  This
> may be a bit of a challenge for udev.c, though.  Is this something
> that people would like to see?

actually modemconf is only for static devices inside embedded systems
like a mobile phone. The desktop should auto-discover modems via udev
and MBM is one of them that get auto-discovered nicely when having a
proper libudev in place.

Regards

Marcel