[PATCH] voicecall: allow P or , within the dial string

[Pekka Pessi <ppessi@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

"DTMF control digit separator" is used as pause according to GSM 02.07.
According to GSM 11.11 it is stored as BCD code 1100 in the SIM card. Nokia
modems use 'p' to represent pause. AT commands use ',' to represent pause.

Note that the interpretation of 'p' and ',' differs when used as a part of a
dial strings. When a dial string is separated from the phone number by ',',
sending the dial string starts after call is alerting. When a dial string is
separated by 'p' (DTMF control digit separator), dial string is sent only
after call is connected.
---
 src/voicecall.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index bd5358c..c69c822 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -1121,6 +1121,12 @@ static DBusMessage *manager_tone(DBusConnection *conn,
 				(tones[i] >= 'A' && tones[i] <= 'D'))
 			continue;
 
+		/* Pause can be described with P or , */
+		if (tones[i] == 'P' || tones[i] == ',') {
+			tones[i] = 'p';
+			continue;
+		}
+
 		g_free(tones);
 		return __ofono_error_invalid_format(msg);
 	}
-- 
1.6.0.4