From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] Work around Palm Pre SIM file reading quirk.
Date: Tue, 10 Nov 2009 09:19:45 +0100 [thread overview]
Message-ID: <1257841185.3024.17.camel@violet> (raw)
In-Reply-To: <1257834610-22409-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
Hi Andrzej,
> I'm not sure if MSM is not a too generic name but it seems the G1's
> Qualcomm MSM suffers from similar problems.
<snip>
> diff --git a/drivers/atmodem/vendor.h b/drivers/atmodem/vendor.h
> index d88444f..5c2613c 100644
> --- a/drivers/atmodem/vendor.h
> +++ b/drivers/atmodem/vendor.h
> @@ -23,4 +23,5 @@ enum ofono_vendor {
> OFONO_VENDOR_GENERIC = 0,
> OFONO_VENDOR_HTC_G1,
> OFONO_VENDOR_CALYPSO,
> + OFONO_VENDOR_MSM,
> };
call it OFONO_VENDOR_QCOM_MSM to be clear that it is Qualcomm specific,
but again we might rename all of these anyway at some point with quirk
names that actually clearly show what they are quirking.
Regards
Marcel
prev parent reply other threads:[~2009-11-10 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 6:30 [PATCH 1/3] Work around Palm Pre SIM file reading quirk Andrzej Zaborowski
2009-11-10 8:19 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257841185.3024.17.camel@violet \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox