Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] emit settings signal before active signal
Date: Sat, 21 Nov 2009 19:14:21 +0100	[thread overview]
Message-ID: <1258827261.22343.28.camel@localhost.localdomain> (raw)
In-Reply-To: <1258801008-9862-1-git-send-email-martin.xu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi Martin

> ---
>  src/gprs.c |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)

quick question on why? I did remember that Denis and I talked about on
IRC, but I forgot what our conclusion on the order of these two signals
was. We should really document this. Do you remember? And please prepare
a patch that also puts a comment about this in the API documentation.

Regards

Marcel



  reply	other threads:[~2009-11-21 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-21 10:56 [PATCH 1/1] emit settings signal before active signal Martin Xu
2009-11-21 18:14 ` Marcel Holtmann [this message]
2009-11-23  5:06   ` Xu, Martin
2009-11-23  8:09     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258827261.22343.28.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox