From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC] HFP support into oFono and BlueZ
Date: Tue, 12 Jan 2010 17:44:44 -0800 [thread overview]
Message-ID: <1263347084.922.1.camel@localhost.localdomain> (raw)
In-Reply-To: <201001121854.59479.denkenz@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Hi Denis,
> Initial impressions:
>
> +static DBusConnection *connection;
> +static char *ofono_handsfree_path;
> +
> +
> +static int timeout;
> +
>
> These globals seem to belong in per-modem user data unless you only want 1 HFP
> device per system?
the DBusConnection is fine as a global since it is shared for the whole
process anyway.
For the other two, I agree, they have to be per modem.
Regards
Marcel
prev parent reply other threads:[~2010-01-13 1:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 17:08 [RFC] HFP support into oFono and BlueZ Gustavo F. Padovan
2010-01-11 19:05 ` Gustavo F. Padovan
2010-01-13 23:39 ` Gustavo F. Padovan
2010-01-18 11:38 ` Luiz Augusto von Dentz
2010-01-17 22:37 ` Denis Kenzior
2010-01-19 8:02 ` Johan Hedberg
2010-01-19 9:30 ` Luiz Augusto von Dentz
2010-01-19 10:33 ` Johan Hedberg
2010-01-19 12:26 ` Luiz Augusto von Dentz
2010-01-20 19:58 ` Gustavo F. Padovan
2010-01-21 6:28 ` Zhang, Zhenhua
2010-01-21 7:54 ` Zhao Forrest
2012-08-21 22:46 ` Lucas De Marchi
2010-01-21 19:22 ` Johan Hedberg
2010-01-21 19:27 ` Johan Hedberg
2010-01-27 19:12 ` HFP support into BlueZ and oFono Gustavo F. Padovan
2010-01-27 19:12 ` [PATCH 1/2] clean up audio/gateway.c Gustavo F. Padovan
2010-01-27 19:12 ` [PATCH 2/2] Implement HandsfreeGateway Interface Gustavo F. Padovan
2010-01-27 19:12 ` [PATCH] Add HFP support through BlueZ Gustavo F. Padovan
2010-01-27 20:17 ` Marcel Holtmann
2010-02-01 3:15 ` [PATCH 1/2] clean up audio/gateway.c Zhenhua Zhang
2010-01-27 19:17 ` HFP support into BlueZ and oFono Gustavo F. Padovan
2010-01-13 0:54 ` [RFC] HFP support into oFono and BlueZ Denis Kenzior
2010-01-13 1:44 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263347084.922.1.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox