From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] Add STE voice call support.
Date: Thu, 28 Jan 2010 17:20:11 +0100 [thread overview]
Message-ID: <1264695611.3227.21.camel@violet> (raw)
In-Reply-To: <1264688583-9253-1-git-send-email-sjur.brandeland@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]
Hi Sjur,
> ---
> Makefile.am | 1 +
> drivers/stemodem/stemodem.c | 2 +
> drivers/stemodem/stemodem.h | 3 +
> drivers/stemodem/voicecall.c | 596 ++++++++++++++++++++++++++++++++++++++++++
> plugins/ste.c | 2 +-
> 5 files changed, 603 insertions(+), 1 deletions(-)
> create mode 100644 drivers/stemodem/voicecall.c
>
> diff --git a/Makefile.am b/Makefile.am
> index ac13d73..ecd2660 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -159,6 +159,7 @@ builtin_sources += drivers/atmodem/atutil.h \
> drivers/stemodem/stemodem.h \
> drivers/stemodem/stemodem.c \
> drivers/stemodem/gprs-context.c \
> + drivers/stemodem/voicecall.c \
> drivers/stemodem/caif_socket.h \
> drivers/stemodem/if_caif.h
>
> diff --git a/drivers/stemodem/stemodem.c b/drivers/stemodem/stemodem.c
> index 53207db..9184a42 100644
> --- a/drivers/stemodem/stemodem.c
> +++ b/drivers/stemodem/stemodem.c
> @@ -37,6 +37,7 @@
> static int stemodem_init(void)
> {
> ste_gprs_context_init();
> + ste_voicecall_init();
>
> return 0;
> }
> @@ -44,6 +45,7 @@ static int stemodem_init(void)
> static void stemodem_exit(void)
> {
> ste_gprs_context_exit();
> + ste_voicecall_exit();
> }
>
> OFONO_PLUGIN_DEFINE(stemodem, "STE modem driver", VERSION,
> diff --git a/drivers/stemodem/stemodem.h b/drivers/stemodem/stemodem.h
> index e55a2c3..e7c6934 100644
> --- a/drivers/stemodem/stemodem.h
> +++ b/drivers/stemodem/stemodem.h
> @@ -25,3 +25,6 @@
> extern void ste_gprs_context_init();
> extern void ste_gprs_context_exit();
>
> +extern void ste_voicecall_init();
> +extern void ste_voicecall_exit();
> +
just a small style issue. Can you put voicecall before GPRS in the init
routines and the Makefile.
Regards
Marcel
next prev parent reply other threads:[~2010-01-28 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 14:23 [PATCH] Add STE voice call support sjur.brandeland
2010-01-28 16:20 ` Marcel Holtmann [this message]
2010-01-28 21:13 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264695611.3227.21.camel@violet \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox