Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 6/6] Add PPP option to gsmdial
Date: Mon, 22 Mar 2010 23:30:16 -0700	[thread overview]
Message-ID: <1269325816.11714.28.camel@localhost.localdomain> (raw)
In-Reply-To: <20100323053034.GA17646@vigoh>

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi Gustavo,

> > +static void connect_cb(gboolean ok, GAtResult *result, gpointer user_data)
> > +{
> > +	GIOChannel *channel;
> > +
> > +	if (!ok) {
> > +		g_print("Unable to define context\n");
> > +		exit(1);
> 
> I guess we should not call exit here. Just return.

it is a test program. So it doesn't really matter. We will never install
this program. It is just for the developers ;)

Regards

Marcel



  reply	other threads:[~2010-03-23  6:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23  0:05 [PATCH 0/6] PPP Patches v3 Kristen Carlson Accardi
2010-03-23  0:05 ` [PATCH 1/6] Basic PPP protocol support Kristen Carlson Accardi
2010-03-23  0:05 ` [PATCH 2/6] Generic PPP control " Kristen Carlson Accardi
2010-03-23  0:05 ` [PATCH 3/6] PPP LCP support Kristen Carlson Accardi
2010-03-23  0:05 ` [PATCH 4/6] CHAP with MD5 authentication support Kristen Carlson Accardi
2010-03-23  0:06 ` [PATCH 5/6] IP support for PPP Kristen Carlson Accardi
2010-03-23  0:06 ` [PATCH 6/6] Add PPP option to gsmdial Kristen Carlson Accardi
2010-03-23  5:30   ` Gustavo F. Padovan
2010-03-23  6:30     ` Marcel Holtmann [this message]
2010-03-23  0:32 ` [PATCH 0/6] PPP Patches v3 Marcel Holtmann
2010-03-23  2:22   ` Marcel Holtmann
2010-03-23  3:22     ` Kristen Carlson Accardi
2010-03-23  3:47       ` Marcel Holtmann
2010-03-23  4:07         ` Kristen Carlson Accardi
2010-03-23  4:51           ` Marcel Holtmann
2010-03-23  6:14             ` Kristen Carlson Accardi
2010-03-23  6:45               ` Marcel Holtmann
2010-03-23 17:16                 ` Kristen Carlson Accardi
2010-03-23 17:34                 ` Kristen Carlson Accardi
2010-03-23 17:56                   ` Marcel Holtmann
2010-03-23 18:26                     ` Kristen Carlson Accardi
2010-03-23 18:37                       ` Denis Kenzior
2010-03-23 19:07                       ` Marcel Holtmann
2010-03-23  3:56       ` Kristen Carlson Accardi
2010-03-23 12:34     ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-03-23 12:49       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269325816.11714.28.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox