Open Source Telephony
 help / color / mirror / Atom feed
From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH 3/3] fix memory leak in ppp_auth
Date: Wed, 24 Mar 2010 10:13:25 -0700	[thread overview]
Message-ID: <1269450805-3661-4-git-send-email-kristen@linux.intel.com> (raw)
In-Reply-To: <1269450805-3661-1-git-send-email-kristen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Free packet after calling ppp_transmit()
---
 gatchat/ppp_auth.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
index 2270436..6c3913e 100644
--- a/gatchat/ppp_auth.c
+++ b/gatchat/ppp_auth.c
@@ -112,6 +112,7 @@ static void chap_process_challenge(struct auth_data *auth, guint8 *packet)
 
 	/* transmit the packet */
 	ppp_transmit(auth->ppp, (guint8 *) ppp_packet, response_length);
+	g_free(ppp_packet);
 
 challenge_out:
 	g_checksum_free(checksum);
-- 
1.6.6.1


  parent reply	other threads:[~2010-03-24 17:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 17:13 [PATCH 0/3] fix memory leaks in PPP Kristen Carlson Accardi
2010-03-24 17:13 ` [PATCH 1/3] fix memory leaks in option handling Kristen Carlson Accardi
2010-03-24 17:13 ` [PATCH 2/3] fix memory leaks after ppp_transmit Kristen Carlson Accardi
2010-03-24 17:13 ` Kristen Carlson Accardi [this message]
2010-03-24 20:22 ` [PATCH 0/3] fix memory leaks in PPP Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269450805-3661-4-git-send-email-kristen@linux.intel.com \
    --to=kristen@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox