From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH 2/4] add tracing for PPP terminate path
Date: Wed, 24 Mar 2010 21:41:53 -0700 [thread overview]
Message-ID: <1269492115-15412-3-git-send-email-kristen@linux.intel.com> (raw)
In-Reply-To: <1269492115-15412-1-git-send-email-kristen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]
Insert some calls to pppcp_trace() for future debugging needs.
---
gatchat/ppp_cp.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index 4cc6c13..df14a33 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -399,6 +399,8 @@ static void pppcp_send_terminate_request(struct pppcp_data *data)
struct pppcp_packet *packet;
struct pppcp_timer_data *timer_data = &data->terminate_timer_data;
+ pppcp_trace(data);
+
/*
* the data field can be used by the sender (us).
* leave this empty for now.
@@ -430,6 +432,8 @@ static void pppcp_send_terminate_ack(struct pppcp_data *data,
struct pppcp_packet *packet;
struct pppcp_packet *pppcp_header = (struct pppcp_packet *) request;
+ pppcp_trace(data);
+
packet = pppcp_packet_new(data, TERMINATE_ACK, 0);
/* match identifier of the request */
@@ -621,6 +625,8 @@ static void pppcp_open_event(struct pppcp_data *data, guint8 *packet, guint len)
static void pppcp_close_event(struct pppcp_data *data, guint8* packet, guint len)
{
+ pppcp_trace(data);
+
switch (data->state) {
case INITIAL:
pppcp_transition_state(INITIAL, data);
@@ -1366,6 +1372,8 @@ static guint8 pppcp_process_configure_reject(struct pppcp_data *data,
static guint8 pppcp_process_terminate_request(struct pppcp_data *data,
struct pppcp_packet *packet)
{
+ pppcp_trace(data);
+
return RTR;
}
@@ -1378,6 +1386,8 @@ static guint8 pppcp_process_terminate_ack(struct pppcp_data *data,
* even if the identifiers don't match, we still handle
* a terminate ack, as it is allowed to be unelicited
*/
+ pppcp_trace(data);
+
return RTA;
}
--
1.6.6.1
next prev parent reply other threads:[~2010-03-25 4:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 4:41 [PATCH 0/4] add PPP_DEAD and PPP_TERMINATE support Kristen Carlson Accardi
2010-03-25 4:41 ` [PATCH 1/4] remove unneeded debug statement Kristen Carlson Accardi
2010-03-25 4:41 ` Kristen Carlson Accardi [this message]
2010-03-25 4:41 ` [PATCH 3/4] separate memory cleanup from PPP shutdown Kristen Carlson Accardi
2010-03-25 4:41 ` [PATCH 4/4] gsmdial: shutdown ppp link if we have one Kristen Carlson Accardi
2010-03-25 13:51 ` [PATCH 0/4] add PPP_DEAD and PPP_TERMINATE support Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269492115-15412-3-git-send-email-kristen@linux.intel.com \
--to=kristen@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox