Open Source Telephony
 help / color / mirror / Atom feed
From: Yang Gu <yang.gu@intel.com>
To: ofono@ofono.org
Subject: [PATCH 6/7] Use common bool parser to reimplement immediate response object
Date: Fri, 26 Mar 2010 00:07:35 +0800	[thread overview]
Message-ID: <1269533256-29095-6-git-send-email-yang.gu@intel.com> (raw)
In-Reply-To: <1269533256-29095-5-git-send-email-yang.gu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

---
 src/stkutil.c |   14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/stkutil.c b/src/stkutil.c
index ecf1301..4e42ae4 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -637,18 +637,8 @@ static gboolean parse_dataobj_icon_id(struct comprehension_tlv_iter *iter,
 static gboolean parse_dataobj_imm_resp(struct comprehension_tlv_iter *iter,
 					void *user)
 {
-	gboolean *resp = user;
-
-	if (comprehension_tlv_iter_get_tag(iter) !=
-			STK_DATA_OBJECT_TYPE_IMMEDIATE_RESPONSE)
-		return FALSE;
-
-	if (comprehension_tlv_iter_get_length(iter) != 0)
-		return FALSE;
-
-	*resp = TRUE;
-
-	return TRUE;
+	return parse_dataobj_common_bool(iter, user,
+				STK_DATA_OBJECT_TYPE_IMMEDIATE_RESPONSE);
 }
 
 /* Defined in TS 102.223 Section 8.72 */
-- 
1.6.3.3


  reply	other threads:[~2010-03-25 16:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25 16:07 [PATCH 1/7] Unify some macro names of ber-tlv and comprehension tlv Yang Gu
2010-03-25 16:07 ` [PATCH 2/7] Make the function to parse mcc and mnc public Yang Gu
2010-03-25 16:07   ` [PATCH 3/7] Add parser for location information objects Yang Gu
2010-03-25 16:07     ` [PATCH 4/7] Add parser for imei objects Yang Gu
2010-03-25 16:07       ` [PATCH 5/7] Add parser for common bool object Yang Gu
2010-03-25 16:07         ` Yang Gu [this message]
2010-03-25 16:07           ` [PATCH 7/7] Add parser for help request objects Yang Gu
2010-03-25 16:43             ` Denis Kenzior
2010-03-25 16:43           ` [PATCH 6/7] Use common bool parser to reimplement immediate response object Denis Kenzior
2010-03-25 16:43         ` [PATCH 5/7] Add parser for common bool object Denis Kenzior
2010-03-25 16:42       ` [PATCH 4/7] Add parser for imei objects Denis Kenzior
2010-03-25 16:42     ` [PATCH 3/7] Add parser for location information objects Denis Kenzior
2010-03-25 16:41   ` [PATCH 2/7] Make the function to parse mcc and mnc public Denis Kenzior
2010-03-25 16:41 ` [PATCH 1/7] Unify some macro names of ber-tlv and comprehension tlv Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269533256-29095-6-git-send-email-yang.gu@intel.com \
    --to=yang.gu@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox