From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3936566463816787231==" MIME-Version: 1.0 From: Marcel Holtmann Subject: Re: [PATCH 0/5] ppp: error path fixes Date: Fri, 26 Mar 2010 19:29:00 -0700 Message-ID: <1269656940.11714.190.camel@localhost.localdomain> In-Reply-To: <1269653670-31352-1-git-send-email-kristen@linux.intel.com> List-Id: To: ofono@ofono.org --===============3936566463816787231== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Kristen, > Here are some patches which fix some issues with the error paths in > the PPP control protocol code. > = > Kristen Carlson Accardi (5): > ppp: fix segfault in pppcp_send_code_reject() > ppp: comment fix > ppp: send Protocol-Reject > ppp: use common code to get options from pppcp packet data > ppp: handle Config-Reject > = > gatchat/ppp.c | 29 ++++++--- > gatchat/ppp.h | 1 + > gatchat/ppp_cp.c | 179 +++++++++++++++++++++++++++++++++++++++--------= ----- > gatchat/ppp_cp.h | 2 + > gatchat/ppp_lcp.c | 5 ++ > 5 files changed, 161 insertions(+), 55 deletions(-) all five patches have been applied. Also I pushed the support for NBNS options upstream. With these changes I don't see the endless loop anymore. Problem is still that we can't leave the CHAP secrets empty. For networks where the username and password are not in use, we should be able to leave them empty. Regards Marcel --===============3936566463816787231==--