Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 0/2] ppp authentication bug fixes (resend)
Date: Fri, 26 Mar 2010 23:02:22 -0700	[thread overview]
Message-ID: <1269669742.11714.193.camel@localhost.localdomain> (raw)
In-Reply-To: <1269664610-31900-1-git-send-email-kristen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi Kristen,

> Here are a couple bug fixes for the PPP authentication.  First patch
> fixes the seg fault when the secret is empty, as reported by marcel.
> Second, if we do fail to authenticate, we need to change ppp phases
> to terminate the link.
> 
> Kristen Carlson Accardi (2):
>   ppp: allow empty secret for chap challenge
>   ppp: send PPP_FAIL when authentication fails
> 
>  gatchat/ppp_auth.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

this is funny. Even now patch 1/2 is missing on my side. However it
seems that Denis can see it, so he took care of it.

Regards

Marcel



      parent reply	other threads:[~2010-03-27  6:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-27  4:36 [PATCH 0/2] ppp authentication bug fixes (resend) Kristen Carlson Accardi
2010-03-27  4:36 ` [PATCH 1/2] ppp: allow empty secret for chap challenge Kristen Carlson Accardi
2010-03-27  4:36 ` [PATCH 2/2] ppp: send PPP_FAIL when authentication fails Kristen Carlson Accardi
2010-03-27  6:02 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269669742.11714.193.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox