From: Yang Gu <yang.gu@intel.com>
To: ofono@ofono.org
Subject: [PATCH 08/15] Make function decode_scts public
Date: Fri, 02 Apr 2010 14:20:33 +0800 [thread overview]
Message-ID: <1270189240-11650-8-git-send-email-yang.gu@intel.com> (raw)
In-Reply-To: <1270189240-11650-7-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2508 bytes --]
---
src/smsutil.c | 12 ++++++------
src/smsutil.h | 3 +++
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/smsutil.c b/src/smsutil.c
index 64cd6fb..17e0e0e 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -377,7 +377,7 @@ guint8 sms_decode_semi_octet(guint8 in)
return (in & 0x0f) * 10 + (in >> 4);
}
-static gboolean decode_scts(const unsigned char *pdu, int len,
+gboolean sms_decode_scts(const unsigned char *pdu, int len,
int *offset, struct sms_scts *out)
{
unsigned char oct = 0;
@@ -433,7 +433,7 @@ static gboolean decode_validity_period(const unsigned char *pdu, int len,
return TRUE;
case SMS_VALIDITY_PERIOD_FORMAT_ABSOLUTE:
- if (!decode_scts(pdu, len, offset, &vp->absolute))
+ if (!sms_decode_scts(pdu, len, offset, &vp->absolute))
return FALSE;
return TRUE;
@@ -718,7 +718,7 @@ static gboolean decode_deliver(const unsigned char *pdu, int len,
if (!next_octet(pdu, len, &offset, &out->deliver.dcs))
return FALSE;
- if (!decode_scts(pdu, len, &offset, &out->deliver.scts))
+ if (!sms_decode_scts(pdu, len, &offset, &out->deliver.scts))
return FALSE;
if (!next_octet(pdu, len, &offset, &out->deliver.udl))
@@ -849,7 +849,7 @@ static gboolean decode_submit_report(const unsigned char *pdu, int len,
pi = octet & 0x07;
- if (!decode_scts(pdu, len, &offset, scts))
+ if (!sms_decode_scts(pdu, len, &offset, scts))
return FALSE;
if (pi & 0x01) {
@@ -976,10 +976,10 @@ static gboolean decode_status_report(const unsigned char *pdu, int len,
&out->status_report.raddr))
return FALSE;
- if (!decode_scts(pdu, len, &offset, &out->status_report.scts))
+ if (!sms_decode_scts(pdu, len, &offset, &out->status_report.scts))
return FALSE;
- if (!decode_scts(pdu, len, &offset, &out->status_report.dt))
+ if (!sms_decode_scts(pdu, len, &offset, &out->status_report.dt))
return FALSE;
if (!next_octet(pdu, len, &offset, &octet))
diff --git a/src/smsutil.h b/src/smsutil.h
index fd80c8f..469a49e 100644
--- a/src/smsutil.h
+++ b/src/smsutil.h
@@ -424,6 +424,9 @@ gboolean sms_encode_address_field(const struct sms_address *in, gboolean sc,
guint8 sms_decode_semi_octet(guint8 in);
+gboolean sms_decode_scts(const unsigned char *pdu, int len,
+ int *offset, struct sms_scts *out);
+
int sms_udl_in_bytes(guint8 ud_len, guint8 dcs);
time_t sms_scts_to_time(const struct sms_scts *scts, struct tm *remote);
--
1.6.3.3
next prev parent reply other threads:[~2010-04-02 6:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 6:20 [PATCH 01/15] Add parser for card reader status objects Yang Gu
2010-04-02 6:20 ` [PATCH 02/15] Add parser for card atr objects Yang Gu
2010-04-02 6:20 ` [PATCH 03/15] Add parser for c-apdu objects Yang Gu
2010-04-02 6:20 ` [PATCH 04/15] Add parser for r-apdu objects Yang Gu
2010-04-02 6:20 ` [PATCH 05/15] Add parser for timer identifier objects Yang Gu
2010-04-02 6:20 ` [PATCH 06/15] Refactor function decode_scts to use semi octet decoder Yang Gu
2010-04-02 6:20 ` [PATCH 07/15] Add parser for timer value objects Yang Gu
2010-04-02 6:20 ` Yang Gu [this message]
2010-04-02 6:20 ` [PATCH 09/15] Add parser for date-time and time zone objects Yang Gu
2010-04-02 6:20 ` [PATCH 10/15] Add parser for at command objects Yang Gu
2010-04-02 6:20 ` [PATCH 11/15] Add parser for at response objects Yang Gu
2010-04-02 6:20 ` [PATCH 12/15] Add parser for bc repeat indicator objects Yang Gu
2010-04-02 6:20 ` [PATCH 13/15] Add parser for dtmf string objects Yang Gu
2010-04-02 6:20 ` [PATCH 14/15] Add parser for language objects Yang Gu
2010-04-02 6:20 ` [PATCH 15/15] Add parser for browser identity objects Yang Gu
2010-04-02 16:29 ` [PATCH 01/15] Add parser for card reader status objects Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270189240-11650-8-git-send-email-yang.gu@intel.com \
--to=yang.gu@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox