From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH] ppp: fix missing breaks in switchs
Date: Fri, 02 Apr 2010 13:16:35 -0700 [thread overview]
Message-ID: <1270239395-9618-1-git-send-email-kristen@linux.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
---
gatchat/ppp_cp.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index d5f7c92..cf2f5fa 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -591,7 +591,7 @@ static void pppcp_down_event(struct pppcp_data *data, guint8 *packet, guint len)
case OPENED:
pppcp_transition_state(STARTING, data);
pppcp_this_layer_down(data);
- /* fall through */
+ break;
case INITIAL:
case STARTING:
/* illegal */
@@ -840,7 +840,7 @@ static void pppcp_rca_event(struct pppcp_data *data, guint8 *packet, guint len)
/* scr/6x */
pppcp_send_configure_request(data);
pppcp_transition_state(REQSENT, data);
- /* fall through */
+ break;
case ACKSENT:
pppcp_initialize_restart_count(&data->config_timer_data);
pppcp_this_layer_up(data);
@@ -870,7 +870,7 @@ static void pppcp_rcn_event(struct pppcp_data *data, guint8 *packet, guint len)
case CLOSING:
case STOPPING:
pppcp_transition_state(data->state, data);
- /* fall through */
+ break;
case REQSENT:
pppcp_initialize_restart_count(&data->config_timer_data);
pppcp_send_configure_request(data);
@@ -905,10 +905,9 @@ static void pppcp_rtr_event(struct pppcp_data *data, guint8 *packet, guint len)
switch (data->state) {
case CLOSED:
case STOPPED:
- pppcp_send_terminate_ack(data, packet);
- /* fall through */
case CLOSING:
case STOPPING:
+ pppcp_send_terminate_ack(data, packet);
break;
case REQSENT:
case ACKRCVD:
--
1.6.6.1
next reply other threads:[~2010-04-02 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 20:16 Kristen Carlson Accardi [this message]
2010-04-02 20:20 ` [PATCH] ppp: fix missing breaks in switchs Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270239395-9618-1-git-send-email-kristen@linux.intel.com \
--to=kristen@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox