Re: [PATCH 3/3] huawei: add gprs context

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

Hi Kalle,

> Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid
> SIM.
> ---
> 
>  plugins/huawei.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/huawei.c b/plugins/huawei.c
> index 90fdcf0..fd1528f 100644
> --- a/plugins/huawei.c
> +++ b/plugins/huawei.c
> @@ -41,6 +41,8 @@
>  #include <ofono/gprs.h>
>  #include <ofono/voicecall.h>
>  #include <ofono/log.h>
> +#include <ofono/gprs.h>
> +#include <ofono/gprs-context.h>
>  
>  #include <drivers/atmodem/vendor.h>
>  
> @@ -178,11 +180,19 @@ static void huawei_pre_sim(struct ofono_modem *modem)
>  static void huawei_post_sim(struct ofono_modem *modem)
>  {
>  	struct huawei_data *data = ofono_modem_get_data(modem);
> +	struct ofono_gprs_context *gc;
> +	struct ofono_gprs *gprs;
>  
>  	DBG("%p", modem);
>  
>  	ofono_netreg_create(modem, OFONO_VENDOR_HUAWEI, "atmodem", data->chat);
>  	ofono_sms_create(modem, OFONO_VENDOR_QUALCOMM_MSM, "atmodem", data->chat);
> +
> +	gprs = ofono_gprs_create(modem, 0, "atmodem", data->chat);
> +	gc = ofono_gprs_context_create(modem, 0, "atmodem", data->chat);
> +
> +	if (gprs && gc)
> +		ofono_gprs_add_context(gprs, gc);
>  }

this patch is obviously correct if the PPP part and generic GPRS context
support is working correct. I haven't had time to verify that yet. So
far we only used gsmdial for testing.

Regards

Marcel