From: Yang Gu <yang.gu@intel.com>
To: ofono@ofono.org
Subject: [PATCH 07/19] stkutil: Refactor parser for tone objects
Date: Mon, 10 May 2010 18:38:50 +0800 [thread overview]
Message-ID: <1273487942-27213-7-git-send-email-yang.gu@intel.com> (raw)
In-Reply-To: <1273487942-27213-1-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
---
src/stkutil.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/stkutil.c b/src/stkutil.c
index 0f0ea34..44cef10 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -511,17 +511,8 @@ static gboolean parse_dataobj_text(struct comprehension_tlv_iter *iter,
static gboolean parse_dataobj_tone(struct comprehension_tlv_iter *iter,
void *user)
{
- unsigned char *tone = user;
- const unsigned char *data;
-
- if (comprehension_tlv_iter_get_length(iter) != 1)
- return FALSE;
-
- data = comprehension_tlv_iter_get_data(iter);
-
- *tone = data[0];
-
- return TRUE;
+ unsigned char *byte = user;
+ return parse_dataobj_common_byte(iter, byte);
}
/* Defined in TS 102.223 Section 8.18 */
--
1.7.0.4
next prev parent reply other threads:[~2010-05-10 10:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 10:38 [PATCH 01/19] stkutil: Free default text for get input parser Yang Gu
2010-05-10 10:38 ` [PATCH 02/19] test-stkutil: Add unit test " Yang Gu
2010-05-11 19:25 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 03/19] stk: Unify variable names to use abbreviation Yang Gu
2010-05-11 19:25 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 04/19] test-stkutil: Use enum for icon_id Yang Gu
2010-05-11 19:25 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 05/19] stkutil: Add play tone proactive command parser Yang Gu
2010-05-11 19:26 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 06/19] Replace check_text with check_common_text Yang Gu
2010-05-11 19:26 ` Denis Kenzior
2010-05-10 10:38 ` Yang Gu [this message]
2010-05-11 19:26 ` [PATCH 07/19] stkutil: Refactor parser for tone objects Denis Kenzior
2010-05-10 10:38 ` [PATCH 08/19] test-stkutil: Add unit test for play tone parser Yang Gu
2010-05-11 19:27 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 09/19] stkutil: Add poll interval proactive command parser Yang Gu
2010-05-11 19:23 ` Denis Kenzior
2010-05-12 9:03 ` Gu, Yang
2010-05-12 14:21 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 10/19] test-stkutil: Add unit test for poll interval parser Yang Gu
2010-05-10 10:38 ` [PATCH 11/19] stkutil: Add setup menu proactive command parser Yang Gu
2010-05-11 19:21 ` Denis Kenzior
2010-05-12 8:53 ` Gu, Yang
2010-05-12 14:43 ` Denis Kenzior
2010-05-10 10:38 ` [PATCH 12/19] test-stkutil: Add unit test for setup menu parser Yang Gu
2010-05-10 10:38 ` [PATCH 13/19] stkutil: Add select item proactive command parser Yang Gu
2010-05-10 10:38 ` [PATCH 14/19] test-stkutil: Add unit test for select item parser Yang Gu
2010-05-10 10:38 ` [PATCH 15/19] test-stkutil: Use dedicated functions to check Yang Gu
2010-05-10 10:38 ` [PATCH 16/19] stkutil: Parse cdma tpdu in send sms parser Yang Gu
2010-05-11 19:38 ` Denis Kenzior
2010-05-10 10:39 ` [PATCH 17/19] test-stkutil: Refactor test for " Yang Gu
2010-05-10 10:39 ` [PATCH 18/19] stkutil: Add setup call proactive command parser Yang Gu
2010-05-10 10:39 ` [PATCH 19/19] test-stkutil: Add unit test for setup call parser Yang Gu
2010-05-11 19:24 ` [PATCH 01/19] stkutil: Free default text for get input parser Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273487942-27213-7-git-send-email-yang.gu@intel.com \
--to=yang.gu@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox