From: Yang Gu <yang.gu@intel.com>
To: ofono@ofono.org
Subject: [PATCH 2/2] stktest: Add negative cases for setup menu
Date: Mon, 31 May 2010 19:13:22 +0800 [thread overview]
Message-ID: <1275304402-23708-2-git-send-email-yang.gu@intel.com> (raw)
In-Reply-To: <1275304402-23708-1-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3453 bytes --]
---
unit/test-stkutil.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 64 insertions(+), 0 deletions(-)
diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c
index 7793f3a..b4a5618 100644
--- a/unit/test-stkutil.c
+++ b/unit/test-stkutil.c
@@ -4893,6 +4893,31 @@ static unsigned char setup_menu_913[] = { 0xD0, 0x0D, 0x81, 0x03, 0x01, 0x25,
0x00, 0x82, 0x02, 0x81, 0x82,
0x85, 0x00, 0x8F, 0x00 };
+/* Negative case: No item is present */
+static unsigned char setup_menu_neg_1[] = { 0xD0, 0x0B, 0x81, 0x03, 0x01, 0x25,
+ 0x00, 0x82, 0x02, 0x81, 0x82,
+ 0x85, 0x00 };
+
+/* Negative case: Two empty items*/
+static unsigned char setup_menu_neg_2[] = { 0xD0, 0x0F, 0x81, 0x03, 0x01, 0x25,
+ 0x00, 0x82, 0x02, 0x81, 0x82,
+ 0x85, 0x00, 0x8F, 0x00, 0x8F,
+ 0x00 };
+
+/* Negative case: valid item + empty item */
+static unsigned char setup_menu_neg_3[] = { 0xD0, 0x16, 0x81, 0x03, 0x01, 0x25,
+ 0x00, 0x82, 0x02, 0x81, 0x82,
+ 0x85, 0x00, 0x8F, 0x07, 0x01,
+ 0x49, 0x74, 0x65, 0x6D, 0x20,
+ 0x31, 0x8F, 0x00 };
+
+/* Negative case: empty item + valid item */
+static unsigned char setup_menu_neg_4[] = { 0xD0, 0x16, 0x81, 0x03, 0x01, 0x25,
+ 0x00, 0x82, 0x02, 0x81, 0x82,
+ 0x85, 0x00, 0x8F, 0x00, 0x8F,
+ 0x07, 0x01, 0x49, 0x74, 0x65,
+ 0x6D, 0x20, 0x31 };
+
static struct setup_menu_test setup_menu_data_111 = {
.pdu = setup_menu_111,
.pdu_len = sizeof(setup_menu_111),
@@ -5451,6 +5476,26 @@ static struct setup_menu_test setup_menu_data_913 = {
.qualifier = 0x00
};
+static struct setup_menu_test setup_menu_data_neg_1 = {
+ .pdu = setup_menu_neg_1,
+ .pdu_len = sizeof(setup_menu_neg_1)
+};
+
+static struct setup_menu_test setup_menu_data_neg_2 = {
+ .pdu = setup_menu_neg_2,
+ .pdu_len = sizeof(setup_menu_neg_2)
+};
+
+static struct setup_menu_test setup_menu_data_neg_3 = {
+ .pdu = setup_menu_neg_3,
+ .pdu_len = sizeof(setup_menu_neg_3)
+};
+
+static struct setup_menu_test setup_menu_data_neg_4 = {
+ .pdu = setup_menu_neg_4,
+ .pdu_len = sizeof(setup_menu_neg_4)
+};
+
/* Defined in TS 102.384 Section 27.22.4.7 */
static void test_setup_menu(gconstpointer data)
{
@@ -5484,6 +5529,16 @@ static void test_setup_menu(gconstpointer data)
stk_command_free(command);
}
+static void test_setup_menu_neg(gconstpointer data)
+{
+ const struct setup_menu_test *test = data;
+ struct stk_command *command;
+
+ command = stk_command_new_from_pdu(test->pdu, test->pdu_len);
+
+ g_assert(!command);
+}
+
struct select_item_test {
const unsigned char *pdu;
unsigned int pdu_len;
@@ -16558,6 +16613,15 @@ int main(int argc, char **argv)
g_test_add_data_func("/teststk/Setup Menu 9.1.3",
&setup_menu_data_913, test_setup_menu);
+ g_test_add_data_func("/teststk/Setup Menu Negative 1",
+ &setup_menu_data_neg_1, test_setup_menu_neg);
+ g_test_add_data_func("/teststk/Setup Menu Negative 2",
+ &setup_menu_data_neg_2, test_setup_menu_neg);
+ g_test_add_data_func("/teststk/Setup Menu Negative 3",
+ &setup_menu_data_neg_3, test_setup_menu_neg);
+ g_test_add_data_func("/teststk/Setup Menu Negative 4",
+ &setup_menu_data_neg_4, test_setup_menu_neg);
+
g_test_add_data_func("/teststk/Set Up Menu response 1.1.1",
&set_up_menu_response_data_111,
test_terminal_response_encoding);
--
1.7.0.4
next prev parent reply other threads:[~2010-05-31 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 11:13 [PATCH 1/2] stk: Constraint the appearance of empty item Yang Gu
2010-05-31 11:13 ` Yang Gu [this message]
2010-06-01 19:12 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275304402-23708-2-git-send-email-yang.gu@intel.com \
--to=yang.gu@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox