From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] mbmmodem: Fix ip netmask should be 255.255.255.255
Date: Wed, 23 Jun 2010 08:58:23 +0200 [thread overview]
Message-ID: <1277276303.2301.174.camel@localhost.localdomain> (raw)
In-Reply-To: <1277255191-1335-1-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
Hi Zhenhua,
> Change static IP netmask to 255.255.255.255.
> ---
> drivers/mbmmodem/gprs-context.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mbmmodem/gprs-context.c b/drivers/mbmmodem/gprs-context.c
> index cca5087..2d0e4e2 100644
> --- a/drivers/mbmmodem/gprs-context.c
> +++ b/drivers/mbmmodem/gprs-context.c
> @@ -48,7 +48,7 @@
>
> #define MAX_DNS 5
>
> -#define STATIC_IP_NETMASK "255.255.255.248"
> +#define STATIC_IP_NETMASK "255.255.255.255"
>
> static const char *none_prefix[] = { NULL };
> static const char *e2ipcfg_prefix[] = { "*E2IPCFG:", NULL };
did you see a problem with this or why do you propose this change. The
old f35xx gives this netmask back when using DHCP. What does the f36xx
and later return when using DHCP?
Regards
Marcel
next prev parent reply other threads:[~2010-06-23 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 1:06 [PATCH] mbmmodem: Fix ip netmask should be 255.255.255.255 Zhenhua Zhang
2010-06-23 6:58 ` Marcel Holtmann [this message]
2010-06-23 7:40 ` Zhang, Zhenhua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277276303.2301.174.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox