From: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
To: ofono@ofono.org
Subject: Re: [patch 08/20] sms: document the org.ofono.SMSMessage D-Bus interface
Date: Mon, 26 Jul 2010 13:41:37 -0700 [thread overview]
Message-ID: <1280176897.26204.175.camel@localhost.localdomain> (raw)
In-Reply-To: <4C4DCE82.7090700@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Mon, 2010-07-26 at 11:05 -0700, Denis Kenzior wrote:
> Hi Inaky,
>
> >>> +SMS / Messaging interface
> >>> +=========================
> >>> +
> >>> +Service org.ofono
> >>> +Interface org.ofono.SMSMessage
> >>
> >> oFono API is full CamelCase, so this should be SmsMessage.
> >
> > I disagree. It would be like that if SMS was a word, but it is an
> > acronym. It makes it quite confusing, if you ask me. If that's still how
> > you like it, I'll change it, but I think it is wrong to capitalize an
> > acronym.
> >
>
> Your objection has been noted. However, pure camel case looks nicer and
> that is how most of the API already is (e.g. SmsManager, SimManager,
> UnlockPin, etc) So please change it or name it simply 'Message'.
Changed to SmsMessage as discussed over IRC.
next prev parent reply other threads:[~2010-07-26 20:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 20:59 [patch 00/20] SMS D-Bus support and misc small patches Inaky Perez-Gonzalez
2010-07-23 20:59 ` [patch 01/20] bug.h: Add BUILD_BUG_ON() and friends for compile-time assert checking Inaky Perez-Gonzalez
2010-07-23 21:41 ` Denis Kenzior
2010-07-23 21:57 ` Inaky Perez-Gonzalez
2010-07-23 21:59 ` Denis Kenzior
2010-07-23 20:59 ` [patch 02/20] write_file: make transaction-safe Inaky Perez-Gonzalez
2010-07-23 21:57 ` Denis Kenzior
2010-07-23 22:31 ` Inaky Perez-Gonzalez
2010-07-23 20:59 ` [patch 03/20] manpage: explain debugging options to -d Inaky Perez-Gonzalez
2010-07-23 22:05 ` Denis Kenzior
2010-07-23 20:59 ` [patch 04/20] SMS: introduce message ID API Inaky Perez-Gonzalez
2010-07-27 0:10 ` Denis Kenzior
2010-07-23 20:59 ` [patch 05/20] introduce DECLARE_SMS_ADDR_STR() Inaky Perez-Gonzalez
2010-07-23 22:30 ` Denis Kenzior
2010-07-23 20:59 ` [patch 06/20] _assembly_encode_address: export and rename Inaky Perez-Gonzalez
2010-07-23 22:31 ` Denis Kenzior
2010-07-23 20:59 ` [patch 07/20] SMS: implement SHA256-based message IDs [incomplete] Inaky Perez-Gonzalez
2010-07-27 17:03 ` Denis Kenzior
2010-07-29 21:26 ` Inaky Perez-Gonzalez
2010-07-29 21:37 ` Denis Kenzior
2010-07-31 0:22 ` Inaky Perez-Gonzalez
2010-07-23 20:59 ` [patch 08/20] sms: document the org.ofono.SMSMessage D-Bus interface Inaky Perez-Gonzalez
2010-07-23 23:11 ` Denis Kenzior
2010-07-26 17:19 ` Inaky Perez-Gonzalez
2010-07-26 18:05 ` Denis Kenzior
2010-07-26 20:41 ` Inaky Perez-Gonzalez [this message]
2010-07-23 20:59 ` [patch 09/20] SMS: document handle_sms_status_report() Inaky Perez-Gonzalez
2010-07-23 20:59 ` [patch 10/20] sms_text_prepare: document @use_delivery_reports Inaky Perez-Gonzalez
2010-07-23 23:01 ` Denis Kenzior
2010-07-23 20:59 ` [patch 11/20] SMS: rename create_tx_queue_entry() to tx_queue_entry_new() Inaky Perez-Gonzalez
2010-07-23 23:02 ` Denis Kenzior
2010-07-26 20:49 ` Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 12/20] struct tx_queue_entry: add a destructor Inaky Perez-Gonzalez
2010-07-23 23:06 ` Denis Kenzior
2010-07-23 23:11 ` Inaky Perez-Gonzalez
2010-07-23 23:14 ` Denis Kenzior
2010-07-26 18:48 ` Inaky Perez-Gonzalez
2010-07-26 20:49 ` Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 13/20] SMS: encapsulate D-Bus specific data in 'struct sms_msg_dbus_data' Inaky Perez-Gonzalez
2010-07-27 17:08 ` Denis Kenzior
2010-07-29 21:47 ` Inaky Perez-Gonzalez
2010-07-29 22:17 ` Denis Kenzior
2010-07-29 23:23 ` Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 14/20] SMS: introduce bare state machine and transitions Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 15/20] SMS: introduce Wait-for-Status-Report state and infrastructure Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 16/20] SMS: introduce a state change callback for TX messages Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 17/20] SMS: export outgoing messages over D-Bus Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 18/20] SMS: send D-Bus SMS-MSG::PropertyChanged signals when message changes status Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 19/20] SMS: introduce sms_msg_cancel and its D-Bus wrapper Inaky Perez-Gonzalez
2010-07-27 17:16 ` Denis Kenzior
2010-07-30 23:12 ` Inaky Perez-Gonzalez
2010-07-23 21:00 ` [patch 20/20] SMS: Implement D-Bus SMS-MSG::GetProperties Inaky Perez-Gonzalez
2010-07-27 17:18 ` Denis Kenzior
2010-08-02 19:14 ` Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280176897.26204.175.camel@localhost.localdomain \
--to=inaky.perez-gonzalez@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox