Open Source Telephony
 help / color / mirror / Atom feed
From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH 0/7] add support for icons
Date: Thu, 05 Aug 2010 14:32:33 -0700	[thread overview]
Message-ID: <1281043960-9616-1-git-send-email-kristen@linux.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

This is still a wip, but I wanted to get your feedback on what I've
got so far.  The patch "allow partial reads of files" is still
pretty much what I had before, so I haven't addressed any of your
issues with it.  It still doesn't do files > 256, and I'm just
using the existing read functions with a couple modifications.
I've got some outstanding questions that I noted in comments in
the patches.  

These patches do work with phonesim - so you can play with the
test script if you feel like it.

Kristen Carlson Accardi (7):
  simutil: add fileid for EFimg
  stkutil: change uint32_t to guint32
  sim: read EFimg
  sim: allow partial reads of files
  sim: read an image from an EFiidf
  sim: implement GetIcon dbus interface
  test: add get-icon script

 include/sim.h |   11 +++
 src/sim.c     |  274 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 src/simutil.h |    1 +
 src/stkutil.h |    2 +-
 test/get-icon |   25 +++++
 5 files changed, 302 insertions(+), 11 deletions(-)
 create mode 100755 test/get-icon


             reply	other threads:[~2010-08-05 21:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 21:32 Kristen Carlson Accardi [this message]
2010-08-05 21:32 ` [PATCH 1/7] simutil: add fileid for EFimg Kristen Carlson Accardi
2010-08-05 21:32 ` [PATCH 2/7] stkutil: change uint32_t to guint32 Kristen Carlson Accardi
2010-08-05 21:32 ` [PATCH 3/7] sim: read EFimg Kristen Carlson Accardi
2010-08-05 21:32 ` [PATCH 4/7] sim: allow partial reads of files Kristen Carlson Accardi
2010-08-05 21:32 ` [PATCH 5/7] sim: read an image from an EFiidf Kristen Carlson Accardi
2010-08-05 21:32 ` [PATCH 6/7] sim: implement GetIcon dbus interface Kristen Carlson Accardi
2010-08-05 21:32 ` [PATCH 7/7] test: add get-icon script Kristen Carlson Accardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281043960-9616-1-git-send-email-kristen@linux.intel.com \
    --to=kristen@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox