From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [SMS D-Bus v5 14/17] automake: fix generation of symlinks for headers
Date: Fri, 06 Aug 2010 04:22:23 +0200 [thread overview]
Message-ID: <1281061343.12579.119.camel@localhost.localdomain> (raw)
In-Reply-To: <d1fab71b92d743e419cc05f18c4286deb5b9a447.1281054654.git.inaky.perez-gonzalez@intel.com>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
Hi Inaky,
> When running 'make distcheck' from a vpath build directory (ie: one
> that is not where the source lives), the target headers in
> include/ofono are not generated properly due to a typo in the
> Makefile.am, that is using _srcdir where _buildir should be being
> used.
> ---
> Makefile.am | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index b64ce8e..28d1e77 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -446,7 +446,7 @@ include/ofono/version.h: include/version.h
>
> include/ofono/%.h: include/%.h
> $(AM_V_at)$(MKDIR_P) include/ofono
> - $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
> + $(AM_V_GEN)$(LN_S) $(abs_top_builddir)/$< $@
are we having the same problem in ConnMan. I am seeing only builddir be
used for the version.h generation.
Regards
Marcel
next prev parent reply other threads:[~2010-08-06 2:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 0:55 [SMS D-Bus v5 00/17] pull request Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 01/17] sms: replace sequential SMS message ID with hash Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 02/17] sms: _txq_submit() returns pointer to object Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 03/17] sms: document the org.ofono.SmsMessage interface Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 04/17] sms: document handle_sms_status_report() Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 05/17] sms: introduce bare state machine and transitions Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 06/17] sms: introduce the Wait-for-Status-Report state Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 07/17] sms: introduce a state change callback for messages Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 08/17] sms: export outgoing messages over D-Bus Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 09/17] sms: send PropertyChanged signals on state change Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 10/17] sms: introduce sms_msg_cancel and its D-Bus wrapper Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 11/17] sms: Implement D-Bus SMS-MSG::GetProperties Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 12/17] sms: document SMS Message's D-Bus 'To' property Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 13/17] sms: test code for message's D-Bus GetProperties Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 14/17] automake: fix generation of symlinks for headers Inaky Perez-Gonzalez
2010-08-06 2:22 ` Marcel Holtmann [this message]
2010-08-06 16:53 ` Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 15/17] sms: document variable usage in sms_msg_send() Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 16/17] sms: add test case for message cancel Inaky Perez-Gonzalez
2010-08-06 0:55 ` [SMS D-Bus v5 17/17] sms: add test case for state change signals Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281061343.12579.119.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox