From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 04/16] emulator: Add APIs to send GAtServer result
Date: Thu, 12 Aug 2010 07:52:43 -0400 [thread overview]
Message-ID: <1281613963.12579.269.camel@localhost.localdomain> (raw)
In-Reply-To: <1281493601-14351-5-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi Zhenhua,
> Defines APIs to send final/intermediate/unsolicited result to DUN
> client.
> ---
> include/emulator.h | 2 ++
> src/emulator.c | 28 ++++++++++++++++++++++++++++
> src/ofono.h | 11 +++++++++++
> 3 files changed, 41 insertions(+), 0 deletions(-)
>
> diff --git a/include/emulator.h b/include/emulator.h
> index 29e87b9..2a45c65 100644
> --- a/include/emulator.h
> +++ b/include/emulator.h
> @@ -36,6 +36,8 @@ enum ofono_emulator_status {
> OFONO_EMULATOR_STATUS_DESTROY,
> };
>
> +enum _GAtServerResult;
> +
this is not good. It should not be needed outside of GAtChat. Why not
just include gatserver.h?
And in addition the _GAt declaration should never be used. Why not use
the typedef one?
Regards
Marcel
next prev parent reply other threads:[~2010-08-12 11:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 2:26 [PATCH 00/16] Implement DUN server for oFono Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 01/16] gprs: Rename status_watch to netreg_status_watch Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 02/16] emulator: Add status watches for ofono emulator Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 03/16] emulator: Add emulator status watches in gprs atom Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 04/16] emulator: Add APIs to send GAtServer result Zhenhua Zhang
2010-08-12 11:52 ` Marcel Holtmann [this message]
2010-08-13 1:08 ` Zhang, Zhenhua
2010-08-13 13:06 ` Marcel Holtmann
2010-08-11 2:26 ` [PATCH 05/16] emulator: Implement dialing up for DUN Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 06/16] gprs: Make gprs_proto_to/from_string non-static Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 07/16] emulator: Register mandatory AT command handlers Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 08/16] gprs: Refactor to share remove_context method Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 09/16] gprs: Add DUN +CGATT support in gprs atom Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 10/16] gprs: Add ofono_gprs_create_context method Zhenhua Zhang
2010-08-12 11:57 ` Marcel Holtmann
2010-08-13 1:42 ` Zhang, Zhenhua
2010-08-13 13:04 ` Marcel Holtmann
2010-08-11 2:26 ` [PATCH 11/16] gprs: Add DUN +CGDCONT support in gprs atom Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 12/16] gprs: Add DUN server GPRS connect support Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 13/16] gprs: Add status watch functions Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 14/16] gprs: Add gprs_get_status Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 15/16] emulator: Watch GPRS status changes Zhenhua Zhang
2010-08-11 2:26 ` [PATCH 16/16] emulator: Watch netreg " Zhenhua Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281613963.12579.269.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox