Open Source Telephony
 help / color / mirror / Atom feed
From: Sjur =?unknown-8bit?q?Br=C3=A6ndeland?= <sjurbren@gmail.com>
To: ofono@ofono.org
Subject: [PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.
Date: Mon, 16 Aug 2010 23:12:07 +0200	[thread overview]
Message-ID: <1281993134-3926-2-git-send-email-sjurbren@gmail.com> (raw)
In-Reply-To: <1281993134-3926-1-git-send-email-sjurbren@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

From: Sjur Brændeland <sjur.brandeland@stericsson.com>

---
Marcel Holtmann wrote:
...
>do we really wanna create another vendor quirk here. If both modems
>behave identical then just pass OFONO_VENDOR_MBM in the SIM atom
>registration and be done with it.

Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c

---
 plugins/ste.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/ste.c b/plugins/ste.c
index 9cb49d3..9d9afd6 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -214,7 +214,7 @@ static void ste_pre_sim(struct ofono_modem *modem)
 
 	ofono_devinfo_create(modem, 0, "atmodem", data->chat);
 	sim = ofono_sim_create(modem, 0, "atmodem", data->chat);
-	ofono_voicecall_create(modem, 0, "stemodem", data->chat);
+	ofono_voicecall_create(modem, OFONO_VENDOR_MBM, "stemodem", data->chat);
 
 	if (sim)
 		ofono_sim_inserted_notify(sim, TRUE);
-- 
1.6.3.3


  reply	other threads:[~2010-08-16 21:12 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 13:54 [PATCHv2 0/7] Resubmitting STE Driver patches Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 13:54 ` [PATCHv2 1/7] stemodem: Add support for STK by including MBM implementation Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 14:01   ` Marcel Holtmann
2010-08-16 16:21     ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 13:54 ` [PATCHv2 2/7] atmodem: Enable STE usage of AT*EPEV and AT*EPEE for PIN handling Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 14:03   ` Marcel Holtmann
2010-08-16 13:54 ` [PATCHv2 3/7] stemodem: Add polling for SIM ready Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 13:54 ` [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 14:05   ` Marcel Holtmann
2010-08-16 16:29     ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 16:36       ` Marcel Holtmann
2010-08-16 13:54 ` [PATCHv2 5/7] plugins/ste: Add Radio-Settings Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 13:54 ` [PATCHv2 6/7] stemodem: Use RTNL for creating CAIF interface Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 13:54 ` [PATCHv2 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35 ` [PATCH v3 1/7] plugins/ste: Include STK support from MBM driver Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35   ` [PATCH v3 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35     ` [PATCH v3 3/7] stemodem: Add polling for SIM ready Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35       ` [PATCH v3 4/7] stemodem: Add Radio Settings to STE Modem Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35         ` [PATCH v3 5/7] plugins/ste: Add Radio-Settings Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35           ` [PATCH v3 6/7] stemodem: Use RTNL for creating CAIF interface Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:35             ` [PATCH v3 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 20:45     ` [PATCH v3 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks Marcel Holtmann
2010-08-16 20:44   ` [PATCH v3 1/7] plugins/ste: Include STK support from MBM driver Marcel Holtmann
2010-08-16 21:12 ` [PATCH v4 " Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 21:12   ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?= [this message]
2010-08-16 21:12     ` [PATCH v4 3/7] stemodem: Add polling for SIM ready Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 21:12       ` [PATCH v4 4/7] stemodem: Add Radio Settings to STE Modem Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 21:12         ` [PATCH v4 5/7] plugins/ste: Add Radio-Settings Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 21:12           ` [PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 21:12             ` [PATCH v4 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-16 22:12               ` Marcel Holtmann
2010-08-16 22:11             ` [PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface Marcel Holtmann
2010-08-16 22:05         ` [PATCH v4 4/7] stemodem: Add Radio Settings to STE Modem Marcel Holtmann
2010-08-16 22:08       ` [PATCH v4 3/7] stemodem: Add polling for SIM ready Marcel Holtmann
2010-08-16 22:06     ` [PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks Marcel Holtmann
2010-08-16 21:58   ` [PATCH v4 1/7] plugins/ste: Include STK support from MBM driver Marcel Holtmann
2010-08-17 12:22 ` [PATCH v5 0/8] Resubmitting STE Driver Patches Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:22   ` [PATCH v5 1/8] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:43     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 2/8] stemodem: Add polling for SIM ready Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:58     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 3/8] plugins/ste: Add AT Channel configurations Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:43     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 4/7] stemodem: Add Radio Settings to STE Modem Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:43     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 5/8] plugins/ste: Add Radio-Settings Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:43     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 6/8] plugins/modemconf.c add support for Interface for STE plugin Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:51     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 7/8] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:46     ` Marcel Holtmann
2010-08-17 12:22   ` [PATCH v5 8/8] plugins: Add STE sample to modem.conf Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-17 12:51     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281993134-3926-2-git-send-email-sjurbren@gmail.com \
    --to=sjurbren@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox