From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4531103112886933719==" MIME-Version: 1.0 From: Marcel Holtmann Subject: Re: [PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks. Date: Tue, 17 Aug 2010 00:06:53 +0200 Message-ID: <1281996413.23399.51.camel@localhost.localdomain> In-Reply-To: <1281993134-3926-2-git-send-email-sjurbren@gmail.com> List-Id: To: ofono@ofono.org --===============4531103112886933719== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Sjur, > ... > >do we really wanna create another vendor quirk here. If both modems > >behave identical then just pass OFONO_VENDOR_MBM in the SIM atom > >registration and be done with it. > = > Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c > = > --- > plugins/ste.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > = > diff --git a/plugins/ste.c b/plugins/ste.c > index 9cb49d3..9d9afd6 100644 > --- a/plugins/ste.c > +++ b/plugins/ste.c > @@ -214,7 +214,7 @@ static void ste_pre_sim(struct ofono_modem *modem) > = > ofono_devinfo_create(modem, 0, "atmodem", data->chat); > sim =3D ofono_sim_create(modem, 0, "atmodem", data->chat); > - ofono_voicecall_create(modem, 0, "stemodem", data->chat); > + ofono_voicecall_create(modem, OFONO_VENDOR_MBM, "stemodem", data->chat); I still don't get it. The stemodem/voicecall.c doesn't use any quirks and it should never do so. It is STE specific already. Regards Marcel --===============4531103112886933719==--