Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2] [RfC] doc: Proposed Set Up Call api.
Date: Wed, 18 Aug 2010 08:38:50 +0200	[thread overview]
Message-ID: <1282113530.23399.131.camel@localhost.localdomain> (raw)
In-Reply-To: <4C6B705B.1070400@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Hi Denis,

> > diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
> > index efeae42..dae3ec2 100644
> > --- a/doc/voicecall-api.txt
> > +++ b/doc/voicecall-api.txt
> > @@ -106,3 +106,14 @@ Properties	string LineIdentification [readonly]
> >  			stamped when the call enters the "active" state.
> >  			Client applications can use this to infer somewhat
> >  			reliable call duration information.
> > +
> > +		string Information [readonly, optional]
> > +
> > +			Contains information related to the call for the
> > +			user.  Currently this property is set for calls
> > +			initiated by SIM Toolkit applications.
> > +
> > +		string IconID [readonly, optional]
> > +
> > +			Icon identifier to be used instead of or together
> > +			with the text information.
> 
> So my preference here is simply Icon, or IconIdentifier.  IconID breaks
> our pure CamelCase rules for APIs.

I think we used Icons in STK API and thus this should be Icon to match
with it. But yes, either plain Icon or IconIdentifier.

Regards

Marcel



  parent reply	other threads:[~2010-08-18  6:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17 15:36 [PATCH] list-modems: Pretty-print main menu Andrzej Zaborowski
2010-08-17 15:37 ` [PATCH] stkagent: Free pending call when destroying agent Andrzej Zaborowski
2010-08-18  5:34   ` Denis Kenzior
2010-08-17 15:37 ` [PATCH] calypso: Subscribe to %SIMREM, %SIMINS notifications Andrzej Zaborowski
2010-08-18  5:34   ` Denis Kenzior
2010-08-17 15:37 ` [PATCH] stk: Update agent_called with GetInkey and GetInput support Andrzej Zaborowski
2010-08-18  5:34   ` Denis Kenzior
2010-08-17 15:37 ` [PATCH v2] [RfC] doc: Proposed Set Up Call api Andrzej Zaborowski
2010-08-18  5:32   ` Denis Kenzior
2010-08-18  3:01     ` [PATCH] " Andrzej Zaborowski
2010-08-18 15:03       ` Marcel Holtmann
2010-08-18 17:29       ` Denis Kenzior
2010-08-18  6:38     ` Marcel Holtmann [this message]
2010-08-18  5:33 ` [PATCH] list-modems: Pretty-print main menu Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282113530.23399.131.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox