From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH] simfilesystem: correct sw2 response for binary read
Date: Wed, 18 Aug 2010 04:14:54 -0700 [thread overview]
Message-ID: <1282130094-7586-1-git-send-email-kristen@linux.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
according to spec, sw2 should be the number of bytes read, which
is just length.
---
src/simfilesystem.cpp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/simfilesystem.cpp b/src/simfilesystem.cpp
index d193328..6e05039 100644
--- a/src/simfilesystem.cpp
+++ b/src/simfilesystem.cpp
@@ -226,7 +226,7 @@ void SimFileSystem::crsm( const QString& args )
sw2 = 0x02;
} else if ( length ) {
sw1 = 0x9f;
- sw2 = length - offset;
+ sw2 = length;
response =
QAtUtils::toHex( contents.mid( offset, length ) );
} else {
--
1.7.2.1
next reply other threads:[~2010-08-18 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 11:14 Kristen Carlson Accardi [this message]
2010-08-25 17:46 ` [PATCH] simfilesystem: correct sw2 response for binary read Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282130094-7586-1-git-send-email-kristen@linux.intel.com \
--to=kristen@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox