Re: [PATCH 1/3] mbm: fix initial polling for sim

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

Hi Pekka,

> There seems to be no specific error codes returned when SIM is missing. Poll
> at least 5 times upon an error and give up after that.
> ---
>  plugins/mbm.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/plugins/mbm.c b/plugins/mbm.c
> index 6f71553..bebf5aa 100644
> --- a/plugins/mbm.c
> +++ b/plugins/mbm.c
> @@ -108,10 +108,8 @@ static void simpin_check(gboolean ok, GAtResult *result, gpointer user_data)
>  
>  	DBG("");
>  
> -	/* Modem returns +CME ERROR: 10 if SIM is not ready. */
> -	if (!ok && result->final_or_pdu &&
> -			!strcmp(result->final_or_pdu, "+CME ERROR: 10") &&
> -			data->cpin_poll_count++ < 5) {
> +	/* Modem returns an error if SIM is not ready. */
> +	if (!ok && data->cpin_poll_count++ < 5) {
>  		data->cpin_poll_source =
>  			g_timeout_add_seconds(1, init_simpin_check, modem);

maybe the STE modem is a bit more specific here than the MBM one. Which
MBM modem did you test this with?

Regards

Marcel