From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1174473397408323223==" MIME-Version: 1.0 From: Marcel Holtmann Subject: Re: [PATCH 3/3] mbm: register gprs as STE to utilize STE quirks Date: Fri, 20 Aug 2010 14:14:40 +0200 Message-ID: <1282306480.23399.214.camel@localhost.localdomain> In-Reply-To: <1282207549.23399.165.camel@localhost.localdomain> List-Id: To: ofono@ofono.org --===============1174473397408323223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Pekka, > > No AT+CGEREP=3D2,1 on mbm either. > > --- > > plugins/mbm.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > = > > diff --git a/plugins/mbm.c b/plugins/mbm.c > > index a06c444..e77e61c 100644 > > --- a/plugins/mbm.c > > +++ b/plugins/mbm.c > > @@ -395,7 +395,8 @@ static void mbm_post_sim(struct ofono_modem *modem) > > ofono_cbs_create(modem, 0, "atmodem", data->modem_port); > > ofono_ussd_create(modem, 0, "atmodem", data->modem_port); > > = > > - gprs =3D ofono_gprs_create(modem, 0, "atmodem", data->modem_port); > > + gprs =3D ofono_gprs_create(modem, OFONO_VENDOR_STE, "atmodem", > > + data->modem_port); > > gc =3D ofono_gprs_context_create(modem, 0, "mbm", data->modem_port); > = > looks good, but I actually prefer if we turn this around. Make the quirk > in drivers/atmodem/gprs.c an OFONO_VENDOR_MBM quirk with a proper > comment that this applies to STE and MBM modems. And then have the MBM > and STE plugin use that quirk. I was doing some cleanup and fixed this by myself now while I was at it. Regards Marcel --===============1174473397408323223==--