From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] add cdma relative specs
Date: Mon, 23 Aug 2010 12:43:07 +0200 [thread overview]
Message-ID: <1282560187.23399.233.camel@localhost.localdomain> (raw)
In-Reply-To: <1282556091-3046-1-git-send-email-caiwenzhang@163.com>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
Hi Caiwen,
> ---
> doc/standards.txt | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 85 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 doc/standards.txt
this is still not gonna work out. So first of all your email address
should reflect a proper one. And I expect a proper name in it.
Check with git am and git log on how your email could be applied and how
it would look.
And second please refrain from mode changing files. I know this happens
when you work on FAT file systems or a different OS, but it is not
acceptable. Check the git format-patch results. It clearly should alarm
you if the diffstat shows something like this.
Regards
Marcel
prev parent reply other threads:[~2010-08-23 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 9:34 [PATCH] add cdma relative specs caiwen.zhang
2010-08-23 10:43 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282560187.23399.233.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox