From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Support text mode sms sending and receiving
Date: Tue, 24 Aug 2010 10:56:06 +0200 [thread overview]
Message-ID: <1282640166.6841.10.camel@localhost.localdomain> (raw)
In-Reply-To: <1282631737-15873-1-git-send-email-yong.su@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
Hi Yong,
> ---
> gatchat/gatchat.h | 23 +++++++++++++++++++++++
> 1 files changed, 23 insertions(+), 0 deletions(-)
so Denis has to give a final say on yes or no to these patches, but in
general gatchat.[ch] have to be submitted together. This applies to the
whole project.
Splitting patches into smaller pieces is not splitting them into one
patch per file. Split them into logical chunks and preferable that non
of them break the compilation.
Regards
Marcel
prev parent reply other threads:[~2010-08-24 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 6:35 [PATCH 2/4] Support text mode sms sending and receiving Yong Su
2010-08-24 8:56 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282640166.6841.10.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox