From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] Add support for text mode SMS sending
Date: Tue, 24 Aug 2010 12:45:27 +0200 [thread overview]
Message-ID: <1282646727.6841.18.camel@localhost.localdomain> (raw)
In-Reply-To: <1282645879-25437-1-git-send-email-yong.su@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
Hi Yong,
> +/*
> + * Send AT command with length.
> + * Such as SMS text mode which contains 0x00 or 0x0A, 0x0D
> + */
> +guint g_at_chat_send_with_len(GAtChat *chat, const char *cmd, int cmdlen,
> + const char **prefix_list, GAtResultFunc func,
> + gpointer user_data, GDestroyNotify notify);
> +
so in theory we could handle 0x0a and 0x0d automatically as long as they
are included in "". I don't see a huge problem with that.
What is the 0x00 character used for in an SMS text mode AT command.
Maybe I am missing something obvious, but this needs a bit more details.
Right now I am not liking this split with _with_len() at all.
Regards
Marcel
next prev parent reply other threads:[~2010-08-24 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 10:31 [PATCH] Add support for text mode SMS sending Yong Su
2010-08-24 10:45 ` Marcel Holtmann [this message]
2010-08-24 11:04 ` Su, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282646727.6841.18.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox