From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] sim: add sim_ready_notify
Date: Tue, 24 Aug 2010 23:32:20 +0200 [thread overview]
Message-ID: <1282685540.6841.23.camel@localhost.localdomain> (raw)
In-Reply-To: <1282659854-28097-1-git-send-email-kristen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
Hi Kristen,
> +#define SIM_STATUS_READY 1
> +#define SIM_STATUS_WAITING_FOR_PIN (1 << 1)
> +
as a general rule, I prefer if you also do (1 << 0) instead of 1. Sounds
maybe a bit silly a first, but it make it easier to read and more
consistent. And we let the compiler do the actual optimization ;)
Regards
Marcel
next prev parent reply other threads:[~2010-08-24 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 14:24 [PATCH 1/2] sim: add sim_ready_notify Kristen Carlson Accardi
2010-08-24 14:24 ` [PATCH 2/2] mbm: use sim_ready_notify Kristen Carlson Accardi
2010-08-24 21:32 ` Marcel Holtmann [this message]
2010-08-25 13:32 ` [PATCH 1/2] sim: add sim_ready_notify Pekka Pessi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282685540.6841.23.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox